DATA-43462: Limiting LI ids to bidders

Author: ilya

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java

@@ -218,14 +218,17 @@ private BidRequest updateAllowedBidders(BidRequest bidRequest, List<Eid> resolve
         final Stream<String> missingSources = resolvedSources.stream()
                 .filter(src -> eidPermissions.stream().noneMatch(e -> e.getSource().equals(src)));
 
-        final List<ExtRequestPrebidDataEidPermissions> updatedPermissions = CollectionUtils.union(
-                        missingSources.map(src -> ExtRequestPrebidDataEidPermissions.of(src, this.targetBidders))
-                                .toList(),
+        final Stream<ExtRequestPrebidDataEidPermissions> additionalPermissions = eidPermissions.stream()
+                .filter(e -> !resolvedSources.contains(e.getSource()));
+
+        final List<ExtRequestPrebidDataEidPermissions> updatedPermissions = Stream.of(
+                        additionalPermissions,
+                        missingSources.map(src -> ExtRequestPrebidDataEidPermissions.of(src, this.targetBidders)),
                         existingPermissions.map(p -> ExtRequestPrebidDataEidPermissions.of(
                                 p.getSource(),
-                                CollectionUtils.union(p.getBidders(), this.targetBidders)
-                                        .stream().distinct().toList())).toList())
-                .stream().toList();
+                                Stream.concat(p.getBidders().stream(), this.targetBidders.stream())
+                                        .distinct().toList())))
+                .flatMap(s -> s).toList();
 
         final List<String> bidders = prebidData == null ? this.targetBidders : CollectionUtils.union(this.targetBidders,
                 CollectionUtils.emptyIfNull(prebidData.getBidders())).stream().distinct().toList();

extra/modules/live-intent-omni-channel-identity/src/test/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest.java

@@ -28,6 +28,10 @@
 import org.prebid.server.hooks.v1.auction.AuctionRequestPayload;
 import org.prebid.server.json.JacksonMapper;
 import org.prebid.server.json.ObjectMapperProvider;
+import org.prebid.server.proto.openrtb.ext.request.ExtRequest;
+import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebid;
+import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidData;
+import org.prebid.server.proto.openrtb.ext.request.ExtRequestPrebidDataEidPermissions;
 import org.prebid.server.vertx.httpclient.HttpClient;
 import org.prebid.server.vertx.httpclient.model.HttpClientResponse;
 
@@ -70,12 +74,16 @@ public class LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest {
 
     private LiveIntentOmniChannelIdentityProcessedAuctionRequestHook target;
 
+    private List<String> configuredBidders;
+
     @BeforeEach
     public void setUp() {
+        configuredBidders = List.of("bidder1", "bidder2");
         given(properties.getRequestTimeoutMs()).willReturn(5L);
         given(properties.getIdentityResolutionEndpoint()).willReturn("https://test.com/idres");
         given(properties.getAuthToken()).willReturn("auth_token");
         given(properties.getTreatmentRate()).willReturn(1.0f);
+        given(properties.getTargetBidders()).willReturn(configuredBidders);
 
         target = new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
                 properties, userFpdActivityMask, MAPPER, httpClient, 0.01d);
@@ -365,4 +373,99 @@ public void callShouldReturnFailureWhenRequestingEidsIsFailed() {
                 .isInstanceOf(TimeoutException.class)
                 .hasMessage("Timeout exceeded");
     }
+
+    @Test
+    public void biddersConfiguredRestrictionShouldBeRespected() {
+        final Uid givenUid = Uid.builder().id("id1").atype(2).build();
+        final Eid givenEid = Eid.builder().source("some.source.com").uids(singletonList(givenUid)).build();
+        final User givenUser = User.builder().eids(singletonList(givenEid)).build();
+        final BidRequest givenBidRequest = BidRequest.builder().id("request").user(givenUser).build();
+
+        final ExtRequestPrebidData expectedData = ExtRequestPrebidData.of(configuredBidders, List.of(
+                ExtRequestPrebidDataEidPermissions.of("liveintent.com", configuredBidders)));
+
+        final Eid expectedEid = Eid.builder().source("liveintent.com").build();
+
+        final String responseBody = MAPPER.encodeToString(IdResResponse.of(List.of(expectedEid)));
+        given(httpClient.post(any(), any(), any(), anyLong()))
+                .willReturn(Future.succeededFuture(HttpClientResponse.of(200, null, responseBody)));
+
+        given(auctionInvocationContext.auctionContext()).willReturn(auctionContext);
+        given(auctionContext.getActivityInfrastructure()).willReturn(activityInfrastructure);
+        given(activityInfrastructure.isAllowed(any(), any())).willReturn(true);
+        given(userFpdActivityMask.maskUser(any(), eq(false), eq(false)))
+                .willAnswer(invocation -> invocation.getArgument(0));
+        given(userFpdActivityMask.maskDevice(any(), eq(false), eq(false)))
+                .willAnswer(invocation -> invocation.getArgument(0));
+
+        // when
+        final InvocationResult<AuctionRequestPayload> result =
+                target.call(AuctionRequestPayloadImpl.of(givenBidRequest), auctionInvocationContext).result();
+        // then
+        assertThat(result.status()).isEqualTo(InvocationStatus.success);
+        assertThat(result.payloadUpdate().apply(AuctionRequestPayloadImpl.of(givenBidRequest)))
+                .extracting(AuctionRequestPayload::bidRequest)
+                .extracting(BidRequest::getExt)
+                .extracting(ExtRequest::getPrebid)
+                .extracting(ExtRequestPrebid::getData)
+                .isEqualTo(expectedData);
+
+        verify(httpClient).post(
+                eq("https://test.com/idres"),
+                argThat(headers -> headers.contains("Authorization", "Bearer auth_token", true)),
+                eq(MAPPER.encodeToString(givenBidRequest)),
+                eq(5L));
+    }
+
+    @Test
+    public void biddersConfiguredRestrictionShouldBeMergedWithProvided() {
+        // given
+        final Uid givenUid = Uid.builder().id("id1").atype(2).build();
+        final Eid givenEid = Eid.builder().source("some.source.com").uids(singletonList(givenUid)).build();
+        final User givenUser = User.builder().eids(singletonList(givenEid)).build();
+        final BidRequest givenBidRequest = BidRequest.builder().id("request").user(givenUser).ext(ExtRequest.of(
+                ExtRequestPrebid.builder().data(ExtRequestPrebidData.of(List.of("bidder3"), List.of(
+                        ExtRequestPrebidDataEidPermissions.of("some.other-source.com", List.of("bidder3")),
+                        ExtRequestPrebidDataEidPermissions.of("some.source.com", List.of("bidder3"))))
+                ).build())).build();
+
+        final List<String> expectedBidders = List.of("bidder3", "bidder2", "bidder1");
+
+        final ExtRequestPrebidData expectedData = ExtRequestPrebidData.of(expectedBidders, List.of(
+                ExtRequestPrebidDataEidPermissions.of("some.other-source.com", List.of("bidder3")),
+                ExtRequestPrebidDataEidPermissions.of("some.source.com", List.of("bidder3")),
+                ExtRequestPrebidDataEidPermissions.of("liveintent.com", configuredBidders)));
+
+        final Eid expectedEid = Eid.builder().source("liveintent.com").build();
+
+        final String responseBody = MAPPER.encodeToString(IdResResponse.of(List.of(expectedEid)));
+        given(httpClient.post(any(), any(), any(), anyLong()))
+                .willReturn(Future.succeededFuture(HttpClientResponse.of(200, null, responseBody)));
+
+        given(auctionInvocationContext.auctionContext()).willReturn(auctionContext);
+        given(auctionContext.getActivityInfrastructure()).willReturn(activityInfrastructure);
+        given(activityInfrastructure.isAllowed(any(), any())).willReturn(true);
+        given(userFpdActivityMask.maskUser(any(), eq(false), eq(false)))
+                .willAnswer(invocation -> invocation.getArgument(0));
+        given(userFpdActivityMask.maskDevice(any(), eq(false), eq(false)))
+                .willAnswer(invocation -> invocation.getArgument(0));
+
+        // when
+        final InvocationResult<AuctionRequestPayload> result =
+                target.call(AuctionRequestPayloadImpl.of(givenBidRequest), auctionInvocationContext).result();
+        // then
+        assertThat(result.status()).isEqualTo(InvocationStatus.success);
+        assertThat(result.payloadUpdate().apply(AuctionRequestPayloadImpl.of(givenBidRequest)))
+                .extracting(AuctionRequestPayload::bidRequest)
+                .extracting(BidRequest::getExt)
+                .extracting(ExtRequest::getPrebid)
+                .extracting(ExtRequestPrebid::getData)
+                .isEqualTo(expectedData);
+
+        verify(httpClient).post(
+                eq("https://test.com/idres"),
+                argThat(headers -> headers.contains("Authorization", "Bearer auth_token", true)),
+                eq(MAPPER.encodeToString(givenBidRequest)),
+                eq(5L));
+    }
 }