Code review CTMBNara

Author: t-sormonte

src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java

@@ -103,7 +103,7 @@ private ExtImpSparteo parseExtImp(Imp imp) {
         }
     }
 
-    private ObjectNode modifyImpExt(Imp imp) {
+    private static ObjectNode modifyImpExt(Imp imp) {
         final ObjectNode modifiedImpExt = imp.getExt().deepCopy();
         final ObjectNode sparteoNode = modifiedImpExt.putObject("sparteo");
         final JsonNode bidderJsonNode = modifiedImpExt.remove("bidder");

src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java

@@ -39,15 +39,18 @@
 
 public class SparteoBidderTest extends VertxTest {
 
-    private static final String ENDPOINT_URL =
-            "https://test.sparteo.com/endpoint";
+    private static final String ENDPOINT_URL = "https://test.sparteo.com/endpoint";
     private final SparteoBidder sparteoBidder = new SparteoBidder(ENDPOINT_URL, jacksonMapper);
 
     @Test
     public void creationShouldFailOnInvalidEndpointUrl() {
+        // given
+        final String invalidUrl = "invalid_url";
+
+        // when and then
         assertThatIllegalArgumentException()
-                .isThrownBy(() -> new SparteoBidder("invalid_url", jacksonMapper))
-                .withMessage("URL supplied is not valid: invalid_url");
+                .isThrownBy(() -> new SparteoBidder(invalidUrl, jacksonMapper))
+                .withMessage("URL supplied is not valid: " + invalidUrl);
     }
 
     @Test