Skip to content

Commit cc3e092

Browse files
committed
fix comments
1 parent 4d6a603 commit cc3e092

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/config/LiveIntentOmniChannelIdentityConfiguration.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.prebid.server.hooks.v1.Module;
77
import org.prebid.server.json.JacksonMapper;
88
import org.prebid.server.vertx.httpclient.HttpClient;
9+
import org.springframework.beans.factory.annotation.Value;
910
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
1011
import org.springframework.boot.context.properties.ConfigurationProperties;
1112
import org.springframework.context.annotation.Bean;
@@ -30,11 +31,12 @@ LiveIntentOmniChannelProperties properties() {
3031
@Bean
3132
Module liveIntentOmniChannelIdentityModule(LiveIntentOmniChannelProperties properties,
3233
JacksonMapper mapper,
33-
HttpClient httpClient) {
34+
HttpClient httpClient,
35+
@Value("${logging.sampling-rate:0.01}") double logSamplingRate) {
3436

3537
final LiveIntentOmniChannelIdentityProcessedAuctionRequestHook hook =
3638
new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
37-
properties, mapper, httpClient, () -> ThreadLocalRandom.current().nextLong());
39+
properties, mapper, httpClient, () -> ThreadLocalRandom.current().nextLong(), logSamplingRate);
3840

3941
return new LiveIntentOmniChannelIdentityModule(Collections.singleton(hook));
4042
}

extra/modules/live-intent-omni-channel-identity/src/main/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/hooks/LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import org.prebid.server.hooks.v1.auction.AuctionRequestPayload;
1818
import org.prebid.server.hooks.v1.auction.ProcessedAuctionRequestHook;
1919
import org.prebid.server.json.JacksonMapper;
20-
import org.prebid.server.log.Logger;
20+
import org.prebid.server.log.ConditionalLogger;
2121
import org.prebid.server.log.LoggerFactory;
2222
import org.prebid.server.util.HttpUtil;
2323
import org.prebid.server.util.ListUtil;
@@ -31,25 +31,29 @@
3131

3232
public class LiveIntentOmniChannelIdentityProcessedAuctionRequestHook implements ProcessedAuctionRequestHook {
3333

34-
private static final Logger logger = LoggerFactory.getLogger(
35-
LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.class);
34+
private static final ConditionalLogger conditionalLogger = new ConditionalLogger(LoggerFactory.getLogger(
35+
LiveIntentOmniChannelIdentityProcessedAuctionRequestHook.class));
36+
3637
private static final String CODE = "liveintent-omni-channel-identity-enrichment-hook";
3738

3839
private final LiveIntentOmniChannelProperties config;
3940
private final JacksonMapper mapper;
4041
private final HttpClient httpClient;
4142
private final RandomGenerator random;
43+
private final double logSamplingRate;
4244

4345
public LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(LiveIntentOmniChannelProperties config,
4446
JacksonMapper mapper,
4547
HttpClient httpClient,
46-
RandomGenerator random) {
48+
RandomGenerator random,
49+
double logSamplingRate) {
4750

4851
this.config = Objects.requireNonNull(config);
4952
HttpUtil.validateUrlSyntax(config.getIdentityResolutionEndpoint());
5053
this.mapper = Objects.requireNonNull(mapper);
5154
this.httpClient = Objects.requireNonNull(httpClient);
5255
this.random = Objects.requireNonNull(random);
56+
this.logSamplingRate = logSamplingRate;
5357
}
5458

5559
@Override
@@ -60,8 +64,8 @@ public Future<InvocationResult<AuctionRequestPayload>> call(AuctionRequestPayloa
6064
? noAction()
6165
: requestIdentities(auctionRequestPayload.bidRequest())
6266
.<InvocationResult<AuctionRequestPayload>>map(this::update)
63-
.onFailure(throwable -> logger.error("Failed enrichment:", throwable));
64-
67+
.onFailure(throwable -> conditionalLogger.error(
68+
"Failed enrichment: %s".formatted(throwable.getMessage()), logSamplingRate));
6569
}
6670

6771
private Future<IdResResponse> requestIdentities(BidRequest bidRequest) {

extra/modules/live-intent-omni-channel-identity/src/test/java/org/prebid/server/hooks/modules/liveintent/omni/channel/identity/v1/LiveIntentOmniChannelIdentityProcessedAuctionRequestHookTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,16 @@ public void setUp() {
6464
given(properties.getTreatmentRate()).willReturn(0.9f);
6565
given(random.nextFloat()).willReturn(0.89f);
6666

67-
target = new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(properties, MAPPER, httpClient, random);
67+
target = new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
68+
properties, MAPPER, httpClient, random, 0.01d);
6869
}
6970

7071
@Test
7172
public void creationShouldFailOnInvalidIdentityUrl() {
7273
given(properties.getIdentityResolutionEndpoint()).willReturn("invalid_url");
7374
assertThatIllegalArgumentException().isThrownBy(() ->
74-
new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(properties, MAPPER, httpClient, random));
75+
new LiveIntentOmniChannelIdentityProcessedAuctionRequestHook(
76+
properties, MAPPER, httpClient, random, 0.01d));
7577
}
7678

7779
@Test

0 commit comments

Comments
 (0)