Insticator: fix video validation logic (#3724)

Author: Net-burst

src/main/java/org/prebid/server/bidder/insticator/InsticatorBidder.java

@@ -109,7 +109,7 @@ private void validateImp(Imp imp) {
 
         if (isInvalidDimension(video.getH())
                 || isInvalidDimension(video.getW())
-                || CollectionUtils.isNotEmpty(video.getMimes())) {
+                || CollectionUtils.isEmpty(video.getMimes())) {
 
             throw new PreBidException("One or more invalid or missing video field(s) w, h, mimes");
         }

src/test/java/org/prebid/server/bidder/insticator/InsticatorBidderTest.java

@@ -33,6 +33,7 @@
 
 import java.math.BigDecimal;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import java.util.Set;
 import java.util.function.UnaryOperator;
@@ -449,11 +450,12 @@ public void makeHttpRequestsShouldMakeOneRequestWhenOneImpIsValidAndAnotherAreIn
         final BidRequest bidRequest = givenBidRequest(
                 imp -> imp.id("givenImpId1").ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode()))),
                 imp -> imp.id("givenImpId2"),
-                imp -> imp.id("givenImpId3").video(Video.builder().mimes(null).build()),
-                imp -> imp.id("givenImpId4").video(Video.builder().h(null).build()),
-                imp -> imp.id("givenImpId5").video(Video.builder().h(0).build()),
-                imp -> imp.id("givenImpId6").video(Video.builder().w(null).build()),
-                imp -> imp.id("givenImpId7").video(Video.builder().w(0).build()));
+                imp -> imp.id("givenImpId3").video(givenVideo(video -> video.mimes(null))),
+                imp -> imp.id("givenImpId3").video(givenVideo(video -> video.mimes(Collections.emptyList()))),
+                imp -> imp.id("givenImpId4").video(givenVideo(video -> video.h(null))),
+                imp -> imp.id("givenImpId5").video(givenVideo(video -> video.h(0))),
+                imp -> imp.id("givenImpId6").video(givenVideo(video -> video.w(null))),
+                imp -> imp.id("givenImpId7").video(givenVideo(video -> video.w(0))));
 
         //when
         final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
@@ -569,6 +571,14 @@ private static Imp givenImp(UnaryOperator<Imp.ImpBuilder> impCustomizer) {
                 .build();
     }
 
+    private static Video givenVideo(UnaryOperator<Video.VideoBuilder> videoCustomizer) {
+        return videoCustomizer.apply(Video.builder()
+                        .mimes(List.of("video/mp4"))
+                        .h(100)
+                        .w(100))
+                .build();
+    }
+
     private static ObjectNode givenImpExt(String adUnitId) {
         return givenImpExt(adUnitId, "publisherId");
     }