Skip to content

Commit ea43526

Browse files
osulzhenkoosulzhenko
committed
fix functional tests
1 parent 67b0a37 commit ea43526

File tree

1 file changed

+22
-19
lines changed

1 file changed

+22
-19
lines changed

‎src/test/groovy/org/prebid/server/functional/tests/StoredResponseSpec.groovy‎

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@ import org.prebid.server.functional.model.response.auction.BidResponse
1010
import org.prebid.server.functional.model.response.auction.ErrorType
1111
import org.prebid.server.functional.model.response.auction.SeatBid
1212
import org.prebid.server.functional.service.PrebidServerException
13+
import org.prebid.server.functional.service.PrebidServerService
1314
import org.prebid.server.functional.util.PBSUtils
1415
import spock.lang.PendingFeature
1516

1617
import static org.prebid.server.functional.model.bidder.BidderName.GENERIC
1718

1819
class StoredResponseSpec extends BaseSpec {
1920

21+
private final PrebidServerService pbsService = pbsServiceFactory.getService(["cache.default-ttl-seconds.banner": ""])
22+
2023
@PendingFeature
2124
def "PBS should not fail auction with storedAuctionResponse when request bidder params doesn't satisfy json-schema"() {
2225
given: "BidRequest with bad bidder datatype and storedAuctionResponse"
@@ -33,7 +36,7 @@ class StoredResponseSpec extends BaseSpec {
3336
storedResponseDao.save(storedResponse)
3437

3538
when: "PBS processes auction request"
36-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
39+
def response = pbsService.sendAuctionRequest(bidRequest)
3740

3841
then: "Response should not contain errors and warnings"
3942
assert !response.ext?.errors
@@ -56,7 +59,7 @@ class StoredResponseSpec extends BaseSpec {
5659
storedResponseDao.save(storedResponse)
5760

5861
when: "PBS processes auction request"
59-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
62+
def response = pbsService.sendAuctionRequest(bidRequest)
6063

6164
then: "Response should contain information from stored auction response"
6265
assert response.id == bidRequest.id
@@ -82,7 +85,7 @@ class StoredResponseSpec extends BaseSpec {
8285
storedResponseDao.save(storedResponse)
8386

8487
when: "PBS processes auction request"
85-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
88+
def response = pbsService.sendAuctionRequest(bidRequest)
8689

8790
then: "Response should contain information from stored bid response"
8891
assert response.id == bidRequest.id
@@ -111,7 +114,7 @@ class StoredResponseSpec extends BaseSpec {
111114
storedResponseDao.save(storedResponse)
112115

113116
when: "PBS processes auction request"
114-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
117+
def response = pbsService.sendAuctionRequest(bidRequest)
115118

116119
then: "Response should contain information from stored bid response and change bid.impId on imp.id"
117120
assert response.id == bidRequest.id
@@ -140,7 +143,7 @@ class StoredResponseSpec extends BaseSpec {
140143
storedResponseDao.save(storedResponse)
141144

142145
when: "PBS processes auction request"
143-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
146+
def response = pbsService.sendAuctionRequest(bidRequest)
144147

145148
then: "Response should contain warning information"
146149
assert response.ext?.warnings[ErrorType.PREBID]*.code == [999]
@@ -161,7 +164,7 @@ class StoredResponseSpec extends BaseSpec {
161164
}
162165

163166
when: "PBS processes auction request"
164-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
167+
def response = pbsService.sendAuctionRequest(bidRequest)
165168

166169
then: "Response should contain same stored auction response as requested"
167170
assert response.seatbid == [storedAuctionResponse]
@@ -190,7 +193,7 @@ class StoredResponseSpec extends BaseSpec {
190193
storedResponseDao.save(storedResponse)
191194

192195
when: "PBS processes auction request"
193-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
196+
def response = pbsService.sendAuctionRequest(bidRequest)
194197

195198
then: "Response should contain same stored auction response as requested"
196199
assert response.seatbid == [storedAuctionResponse]
@@ -214,7 +217,7 @@ class StoredResponseSpec extends BaseSpec {
214217
storedResponseDao.save(storedResponse)
215218

216219
when: "PBS processes auction request"
217-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
220+
def response = pbsService.sendAuctionRequest(bidRequest)
218221

219222
then: "Response should contain same stored auction response as requested"
220223
assert response.seatbid
@@ -244,7 +247,7 @@ class StoredResponseSpec extends BaseSpec {
244247
storedResponseDao.save(storedResponse)
245248

246249
when: "PBS processes auction request"
247-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
250+
def response = pbsService.sendAuctionRequest(bidRequest)
248251

249252
then: "Response should contain warning information"
250253
assert response.ext?.warnings[ErrorType.PREBID]*.message.contains('SeatBid can\'t be null in stored response')
@@ -257,10 +260,10 @@ class StoredResponseSpec extends BaseSpec {
257260
given: "Default basic BidRequest with stored response"
258261
def bidRequest = BidRequest.defaultBidRequest
259262
def storedAuctionResponse = SeatBid.getStoredResponse(bidRequest)
260-
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: storedAuctionResponse)
263+
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: storedAuctionResponse)
261264

262265
when: "PBS processes auction request"
263-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
266+
def response = pbsService.sendAuctionRequest(bidRequest)
264267

265268
then: "Response should contain same stored auction response as requested"
266269
assert convertToComparableSeatBid(response.seatbid) == [storedAuctionResponse]
@@ -272,10 +275,10 @@ class StoredResponseSpec extends BaseSpec {
272275
def "PBS should throw error when imp.ext.prebid.storedBidResponse.seatbidobj is with empty seatbid"() {
273276
given: "Default basic BidRequest with empty stored response"
274277
def bidRequest = BidRequest.defaultBidRequest
275-
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: new SeatBid())
278+
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: new SeatBid())
276279

277280
when: "PBS processes auction request"
278-
defaultPbsService.sendAuctionRequest(bidRequest)
281+
pbsService.sendAuctionRequest(bidRequest)
279282

280283
then: "PBS throws an exception"
281284
def exception = thrown(PrebidServerException)
@@ -289,10 +292,10 @@ class StoredResponseSpec extends BaseSpec {
289292
def "PBS should throw error when imp.ext.prebid.storedBidResponse.seatbidobj is with empty bids"() {
290293
given: "Default basic BidRequest with empty bids for stored response"
291294
def bidRequest = BidRequest.defaultBidRequest
292-
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: new SeatBid(bid: [], seat: GENERIC))
295+
bidRequest.imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBidObject: new SeatBid(bid: [], seat: GENERIC))
293296

294297
when: "PBS processes auction request"
295-
defaultPbsService.sendAuctionRequest(bidRequest)
298+
pbsService.sendAuctionRequest(bidRequest)
296299

297300
then: "PBS throws an exception"
298301
def exception = thrown(PrebidServerException)
@@ -313,7 +316,7 @@ class StoredResponseSpec extends BaseSpec {
313316
}
314317

315318
when: "PBS processes auction request"
316-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
319+
def response = pbsService.sendAuctionRequest(bidRequest)
317320

318321
then: "Response should contain same stored auction response as requested"
319322
assert convertToComparableSeatBid(response.seatbid) == [storedAuctionResponse]
@@ -329,7 +332,7 @@ class StoredResponseSpec extends BaseSpec {
329332
}
330333

331334
when: "PBS processes auction request"
332-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
335+
def response = pbsService.sendAuctionRequest(bidRequest)
333336

334337
then: "Response should contain same stored auction response bids as requested"
335338
assert convertToComparableSeatBid(response.seatbid).bid.flatten().sort() ==
@@ -343,15 +346,15 @@ class StoredResponseSpec extends BaseSpec {
343346
given: "Default basic BidRequest with stored response"
344347
def bidRequest = BidRequest.defaultBidRequest
345348
def storedAuctionResponse = SeatBid.getStoredResponse(bidRequest)
346-
bidRequest.tap{
349+
bidRequest.tap {
347350
imp[0].ext.prebid.storedAuctionResponse = new StoredAuctionResponse().tap {
348351
seatBidObject = SeatBid.getStoredResponse(bidRequest)
349352
}
350353
ext.prebid.storedAuctionResponse = new StoredAuctionResponse(seatBids: [storedAuctionResponse])
351354
}
352355

353356
when: "PBS processes auction request"
354-
def response = defaultPbsService.sendAuctionRequest(bidRequest)
357+
def response = pbsService.sendAuctionRequest(bidRequest)
355358

356359
then: "Response should contain same stored auction response as requested"
357360
assert response.seatbid == [storedAuctionResponse]

0 commit comments

Comments
 (0)