Skip to content

Commit f1f8218

Browse files
author
Samuel Alejandro Maldonado Garcia
committed
added integration test
1 parent e0a4564 commit f1f8218

File tree

7 files changed

+59
-62
lines changed

7 files changed

+59
-62
lines changed

‎src/main/java/org/prebid/server/bidder/alvads/AlvadsBidder.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class AlvadsBidder implements Bidder<AlvadsRequestOrtb> {
4444
private final JacksonMapper mapper;
4545

4646
public AlvadsBidder(String endpointUrl, JacksonMapper mapper) {
47-
this.endpointUrl = HttpUtil.validateUrlSyntax(Objects.requireNonNull(endpointUrl));
47+
this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl));
4848
this.mapper = Objects.requireNonNull(mapper);
4949
}
5050

‎src/test/java/org/prebid/server/it/AlvadsTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class AlvadsTest extends IntegrationTest {
1818
@Test
1919
public void openrtb2AuctionShouldRespondWithBidsFromAlvads() throws IOException, JSONException {
2020
// given
21-
WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/decision/openrtb"))
21+
WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/alvads-exchange"))
2222
.withRequestBody(equalToJson(
2323
jsonFrom("openrtb2/alvads/test-alvads-bid-request.json")))
2424
.willReturn(aResponse().withBody(

‎src/test/resources/org/prebid/server/it/openrtb2/alvads/test-alvads-bid-request.json‎

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,34 @@
11
{
2-
"id": "REQ-OPENRTB-1758805437433",
3-
"site": {
4-
"page": "https://facebooktest.com",
5-
"ref": "https://facebooktest.com",
6-
"publisher": {
7-
"id": "D7DACCE3-C23D-4AB9-8FE6-9FF41BF32F8F"
8-
}
9-
},
2+
"id": "tid",
103
"imp": [
114
{
12-
"id": "4776dd98-33c9-4c87-859c-370ee434168c",
5+
"id": "imp1",
136
"banner": {
14-
"w": 250,
7+
"w": 300,
158
"h": 250
169
},
17-
"bidfloor": 0,
18-
"bidfloorcur": "USD",
19-
"ext": {
20-
"userId": "+59172893207"
21-
}
10+
"tagid": "123",
11+
"bidfloor": 0
2212
}
2313
],
2414
"device": {
25-
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64)"
15+
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64)",
16+
"ip": "193.168.244.1"
2617
},
2718
"user": {
2819
"id": "+59172893207",
2920
"buyeruid": "79e917b5-8bb3-4e46-94dc-1053497311f8"
3021
},
3122
"regs": {
32-
"gpp": "",
33-
"gpp_sid": [],
3423
"ext": {
35-
"gdpr": null
24+
"gdpr": 0
3625
}
3726
},
38-
"ext": {
39-
"user_fingerprint": "e061375f-bba1-4a57-98f9-cc072d5a5ad8"
27+
"site": {
28+
"page": "https://facebooktest.com",
29+
"ref": "https://facebooktest.com",
30+
"publisher": {
31+
"id": "D7DACCE3-C23D-4AB9-8FE6-9FF41BF32F8F"
32+
}
4033
}
4134
}

‎src/test/resources/org/prebid/server/it/openrtb2/alvads/test-alvads-bid-response.json‎

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,27 @@
11
{
2-
"id": "request_id",
2+
"id": "tid",
33
"seatbid": [
44
{
55
"bid": [
66
{
7-
"id": "bid_id",
8-
"impid": "imp_id",
7+
"id": "bid001",
8+
"impid": "imp1",
99
"price": 3.33,
1010
"adid": "adid001",
1111
"crid": "crid001",
1212
"cid": "cid001",
1313
"adm": "adm001",
1414
"h": 250,
15-
"w": 250
15+
"w": 300
1616
}
17-
]
17+
],
18+
"seat": "alvads"
1819
}
19-
]
20+
],
21+
"cur": "USD",
22+
"ext": {
23+
"responsetimemillis": {
24+
"alvads": 250
25+
}
26+
}
2027
}

‎src/test/resources/org/prebid/server/it/openrtb2/alvads/test-auction-alvads-request.json‎

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,9 @@
11
{
2-
"id": "test-bid-request",
3-
"site": {
4-
"page": "https://facebooktest.com",
5-
"ref": "https://facebooktest.com",
6-
"publisher": {
7-
"id": "D7DACCE3-C23D-4AB9-8FE6-9FF41BF32F8F"
8-
}
9-
},
10-
"device": {
11-
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64)"
12-
},
13-
"user": {
14-
"id": "+59172893207",
15-
"buyeruid": "79e917b5-8bb3-4e46-94dc-1053497311f8"
16-
},
2+
"id": "tid",
173
"imp": [
184
{
195
"id": "imp1",
20-
"banner": { "w": 250, "h": 250 },
6+
"banner": { "w": 300, "h": 250 },
217
"tagid": "123",
228
"bidfloor": 0,
239
"bidfloorcur": "USD",
@@ -32,10 +18,20 @@
3218
}
3319
}
3420
],
35-
"regs": {
36-
"ext": { "gdpr": 0 }
21+
"device": {
22+
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64)",
23+
"ip": "193.168.244.1"
24+
},
25+
"user": {
26+
"id": "+59172893207",
27+
"buyeruid": "79e917b5-8bb3-4e46-94dc-1053497311f8"
28+
},
29+
"site": {
30+
"page": "https://facebooktest.com",
31+
"ref": "https://facebooktest.com",
32+
"publisher": { "id": "D7DACCE3-C23D-4AB9-8FE6-9FF41BF32F8F" }
3733
},
38-
"ext": {
39-
"user_fingerprint": "e061375f-bba1-4a57-98f9-cc072d5a5ad8"
40-
}
34+
"regs": { "ext": { "gdpr": 0 } },
35+
"ext": { "user_fingerprint": "e061375f-bba1-4a57-98f9-cc072d5a5ad8" },
36+
"tmax": 5000
4137
}

‎src/test/resources/org/prebid/server/it/openrtb2/alvads/test-auction-alvads-response.json‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,28 @@
11
{
2-
"id": "test-bid-request",
2+
"id": "tid",
33
"seatbid": [
44
{
55
"bid": [
66
{
7-
"id": "imp1",
7+
"id": "bid001",
88
"impid": "imp1",
9-
"exp": 300,
10-
"price": 0.2,
9+
"price": 3.33,
1110
"adm": "adm001",
12-
"adid": "adid",
13-
"cid": "323",
14-
"crid": "2142",
15-
"w": 250,
11+
"adid": "adid001",
12+
"cid": "cid001",
13+
"crid": "crid001",
14+
"w": 300,
1615
"h": 250,
16+
"exp": 300,
1717
"ext": {
18-
"alva_format": "Display",
1918
"prebid": {
2019
"type": "banner",
2120
"meta": {
2221
"adaptercode": "alvads"
2322
}
2423
},
25-
"origbidcpm": 0.2,
26-
"origbidcur":"USD"
24+
"origbidcpm": 3.33,
25+
"origbidcur": "USD"
2726
}
2827
}
2928
],
@@ -37,7 +36,7 @@
3736
"alvads": "{{ alvads.response_time_ms }}"
3837
},
3938
"prebid": {
40-
"auctiontimestamp": 0
39+
"auctiontimestamp": 1000
4140
},
4241
"tmaxrequest": 5000
4342
}

‎src/test/resources/org/prebid/server/it/test-application.properties‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ adapters.adverxo.aliases.bidsmind.enabled=true
7272
adapters.adverxo.aliases.bidsmind.endpoint=http://localhost:8090/bidsmind-exchange
7373
adapters.adverxo.aliases.mobupps.enabled=true
7474
adapters.adverxo.aliases.mobupps.endpoint=http://localhost:8090/mobupps-exchange
75+
adapters.alvads.enabled=true
76+
adapters.alvads.endpoint=http://localhost:8090/alvads-exchange
7577
adapters.adview.enabled=true
7678
adapters.adview.endpoint=http://localhost:8090/adview-exchange?accountId={{AccountId}}
7779
adapters.adprime.enabled=true

0 commit comments

Comments
 (0)