set domain to unknown if not defined and add a warning

Author: t-sormonte

src/main/java/org/prebid/server/bidder/sparteo/SparteoBidder.java

@@ -45,6 +45,7 @@ public class SparteoBidder implements Bidder<BidRequest> {
     private static final String NETWORK_ID_MACRO = "{{NetworkId}}";
     private static final String DOMAIN_MACRO = "{{Domain}}";
     private static final String BUNDLE_QUERY_MACRO = "{{BundleQuery}}";
+    private static final String UNKNOWN_DOMAIN = "unknown";
 
     private static final TypeReference<ExtPrebid<?, ExtImpSparteo>> TYPE_REFERENCE =
             new TypeReference<>() { };
@@ -94,7 +95,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
 
         final BidRequest outgoingRequest = builder.build();
 
-        final String finalEndpointUrl = replaceMacros(site, app, networkId);
+        final String finalEndpointUrl = replaceMacros(site, app, networkId, errors);
         final HttpRequest<BidRequest> call = BidderUtil.defaultRequest(outgoingRequest, finalEndpointUrl, mapper);
 
         return Result.of(Collections.singletonList(call), errors);
@@ -182,9 +183,13 @@ private ObjectNode ensureParamsNode(ExtPublisher extPublisher) {
         return paramsNode;
     }
 
-    private String replaceMacros(Site site, App app, String networkId) {
+    private String replaceMacros(Site site, App app, String networkId, List<BidderError> errors) {
         final String domain = resolveDomain(site, app);
         final String bundle = Optional.ofNullable(app).map(App::getBundle).orElse(null);
+        if (StringUtils.isBlank(domain)) {
+            errors.add(BidderError.badInput(
+                    "Domain not found. Missing at least one of this fields: site.domain, site.page, app.domain."));
+        }
         return resolveEndpoint(domain, networkId, bundle);
     }
 
@@ -244,18 +249,15 @@ private String resolveDomain(Site site, App app) {
     }
 
     private String resolveEndpoint(String domain, String networkId, String bundle) {
-        String uri = endpointUrl.replace(NETWORK_ID_MACRO, HttpUtil.encodeUrl(networkId));
-
-        if (domain != null && !domain.isEmpty()) {
-            uri = uri.replace(DOMAIN_MACRO, HttpUtil.encodeUrl(domain));
-        }
+        final String d = StringUtils.isBlank(domain) ? UNKNOWN_DOMAIN : domain;
+        final String uri = endpointUrl
+                .replace(NETWORK_ID_MACRO, HttpUtil.encodeUrl(networkId))
+                .replace(DOMAIN_MACRO, HttpUtil.encodeUrl(d));
 
-        final String bundleQuery = (bundle != null && !bundle.isEmpty())
+        final String bundleQuery = StringUtils.isNotBlank(bundle)
                 ? "&bundle=" + HttpUtil.encodeUrl(bundle)
                 : "";
-        uri = uri.replace(BUNDLE_QUERY_MACRO, bundleQuery);
-
-        return uri;
+        return uri.replace(BUNDLE_QUERY_MACRO, bundleQuery);
     }
 
     @Override

src/test/java/org/prebid/server/bidder/sparteo/SparteoBidderTest.java

@@ -66,10 +66,10 @@ public void makeHttpRequestsShouldSetNetworkIdOnSitePublisherExtWhenPresentInImp
         final Result<List<HttpRequest<BidRequest>>> result = sparteoBidder.makeHttpRequests(bidRequest);
 
         // then
-        assertThat(result.getErrors()).isEmpty();
+        assertMissingDomainWarning(result);
         assertThat(result.getValue())
                 .extracting(HttpRequest::getMethod, HttpRequest::getUri)
-                .containsExactly(tuple(HttpMethod.POST, "https://test.sparteo.com/endpoint?network_id=testNetworkId&domain={{Domain}}"));
+                .containsExactly(tuple(HttpMethod.POST, "https://test.sparteo.com/endpoint?network_id=testNetworkId&domain=unknown"));
 
         assertThat(result.getValue())
                 .extracting(HttpRequest::getPayload)
@@ -107,7 +107,7 @@ public void makeHttpRequestsShouldUseFirstNetworkIdWhenMultipleImpsDefineIt() {
         final Result<List<HttpRequest<BidRequest>>> result = sparteoBidder.makeHttpRequests(bidRequest);
 
         // then
-        assertThat(result.getErrors()).isEmpty();
+        assertMissingDomainWarning(result);
         assertThat(result.getValue())
                 .extracting(HttpRequest::getPayload)
                 .extracting(BidRequest::getSite)
@@ -135,7 +135,7 @@ public void makeHttpRequestsShouldMergeSparteoParamsWithBidderParamsOnConflict()
         final Result<List<HttpRequest<BidRequest>>> result = sparteoBidder.makeHttpRequests(bidRequest);
 
         // then
-        assertThat(result.getErrors()).isEmpty();
+        assertMissingDomainWarning(result);
         assertThat(result.getValue())
                 .extracting(HttpRequest::getPayload)
                 .flatExtracting(BidRequest::getImp)
@@ -170,13 +170,13 @@ public void makeHttpRequestsShouldHandleRequestWithoutSiteOrPublisher() {
                 sparteoBidder.makeHttpRequests(bidRequestNoPublisher);
 
         // then
-        assertThat(resultNoSite.getErrors()).isEmpty();
+        assertMissingDomainWarning(resultNoPublisher);
         assertThat(resultNoSite.getValue())
                 .extracting(HttpRequest::getPayload)
                 .extracting(BidRequest::getSite)
                 .containsNull();
 
-        assertThat(resultNoPublisher.getErrors()).isEmpty();
+        assertMissingDomainWarning(resultNoPublisher);
         final BidRequest out = resultNoPublisher.getValue().get(0).getPayload();
         assertThat(out.getSite()).isNotNull();
         assertThat(out.getSite().getPublisher()).isNotNull();
@@ -207,7 +207,7 @@ public void makeHttpRequestsShouldMergeNetworkIdIntoExistingPublisherExtParams()
         final Result<List<HttpRequest<BidRequest>>> result = sparteoBidder.makeHttpRequests(bidRequest);
 
         // then
-        assertThat(result.getErrors()).isEmpty();
+        assertMissingDomainWarning(result);
         assertThat(result.getValue())
                 .extracting(HttpRequest::getPayload)
                 .extracting(BidRequest::getSite)
@@ -240,7 +240,7 @@ public void makeHttpRequestsShouldAddParamsToPublisherExtWhenExtExistsWithoutPar
         final Result<List<HttpRequest<BidRequest>>> result = sparteoBidder.makeHttpRequests(bidRequest);
 
         // then
-        assertThat(result.getErrors()).isEmpty();
+        assertMissingDomainWarning(result);
         assertThat(result.getValue())
                 .extracting(HttpRequest::getPayload)
                 .extracting(BidRequest::getSite)
@@ -1058,6 +1058,19 @@ private ObjectNode createBidExtWithEmptyPrebid() {
         return bidExt;
     }
 
+    private static void assertMissingDomainWarning(Result<?> result) {
+        assertThat(result.getErrors())
+                .hasSize(1)
+                .allSatisfy(err -> {
+                    assertThat(err.getType()).isEqualTo(BidderError.Type.bad_input);
+                    assertThat(err.getMessage())
+                            .contains(
+                                "Domain not found. "
+                                    + "Missing at least one of this fields: site.domain, site.page, app.domain."
+                            );
+                });
+    }
+
     private static String normalize(String in) {
         try {
             final var m = SparteoBidder.class.getDeclaredMethod("normalizeHostname", String.class);