New Adapter: Clydo #4299
Open
New Adapter: Clydo #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Dec 4, 2025
|
CTMBNara
requested changes
Jan 5, 2026
Comment on lines
159
to
161
| if (bidType == null) { | ||
| throw new PreBidException("Failed to get media type"); | ||
| } |
| @JsonProperty("partnerId") | ||
| String partnerId; | ||
|
|
||
| @JsonProperty("region") |
Collaborator
There was a problem hiding this comment.
No need for JsonProperty here
Comment on lines
31
to
33
| BidderDeps clydoBidderDeps(BidderConfigurationProperties clydoConfigurationProperties, | ||
| @NotBlank @Value("${external-url}") String externalUrl, | ||
| JacksonMapper mapper) { |
CTMBNara
requested changes
Jan 12, 2026
src/test/java/org/prebid/server/bidder/clydo/ClydoBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Jan 13, 2026
Comment on lines
143
to
154
| @Test | ||
| public void makeBidsShouldReturnEmptyListIfBidResponseIsNull() throws JsonProcessingException { | ||
| // given | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall( | ||
| mapper.writeValueAsString(null)); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, null); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()).isEmpty(); |
Collaborator
There was a problem hiding this comment.
Move it to makeBids* tests
| // when | ||
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest); | ||
|
|
||
| //then |
Comment on lines
211
to
226
| @Test | ||
| public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() { | ||
| // given | ||
| final BidderCall<BidRequest> httpCall = givenHttpCall("invalid"); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, null); | ||
|
|
||
| // then | ||
| assertThat(result.getValue()).isEmpty(); | ||
| assertThat(result.getErrors()).hasSize(1) | ||
| .allSatisfy(error -> { | ||
| assertThat(error.getMessage()).startsWith("Failed to decode: Unrecognized token 'invalid':"); | ||
| assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response); | ||
| }); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#4291