-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Scalibur bidder adapter documentation #6235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add complete bidder documentation with all required front matter - Configure support for GDPR, CCPA, GPP, floors, and FPD - Set GVLID to 1471 for proper GDPR compliance - Enable integration with bidders list and search functionality
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@bTimor : can you please fix the rendering of your "Bid params" array within your file please : https://deploy-preview-6235--prebid-docs-preview.netlify.app/dev-docs/bidders/scalibur ? |
Fixed. Thank you |
|
@lpagnypubstack My adapter PR was approved and merged to master. |
|
Hi @patmmccann @muuki88, I noticed you've been actively reviewing recent bidder documentation PRs. My Scalibur adapter documentation has been waiting for review for several weeks after I addressed the "needs work" feedback. The Scalibur bidder adapter was already merged into Prebid.js, and this documentation PR completes the integration. Could you take a look when you have a moment? PR has been kept up-to-date with master and all previous feedback has been addressed. Thanks for your time! |
muuki88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
Thanks for your patience. With Prebid Summit all volunteers were busy.
If you AI generate the documentation, please review yourself first and remove all redundancies yourself. This speeds up the review process and improves the documentation quality. Also use other bidder documentations in your context, so headings and styling are aligned.
|
@muuki88 |
| biddercode: scalibur | ||
| gvl_id: 1471 | ||
| media_types: banner, video | ||
| gpp_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| gpp_supported: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been nice to see this removed. Can you do this in a small PR?
|
@muuki88 Thanks for your review and merge. |
🏷 Type of documentation
📋 Checklist
Description
This PR adds comprehensive documentation for the Scalibur bidder adapter, including:
Bidder Code:
scaliburGVLID: 1471
Media Types: Banner and Video (instream)
Privacy Compliance: Full support for GDPR (TCF EU), CCPA (USP), COPPA, and GPP
Key Features:
Related Pull Requests
Adapter Code PR: prebid/Prebid.js#13826 (will be submitted separately)
The documentation includes detailed configuration examples for banner, video, and multi-format ad units, along with comprehensive setup instructions for publishers.