Lint: Add Async and Bandit rules

Author: Epse

.github/workflows/ci.yml

@@ -19,8 +19,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: astral-sh/setup-uv@v6
       - run: uv python install ${{ matrix.python }}
-      - run: uv run ruff check src/obelisk/
-      - run: uv run ruff format --check src/obelisk/
+      - run: uv run ruff check
+      - run: uv run ruff format
       - run: uv run mypy
   test:
     name: Run tests

hooks/pre-commit

@@ -10,5 +10,5 @@
 # Redirect output to stderr.
 exec 1>&2
 
-uv run ruff format --check src/obelisk/
+uv run ruff format --check
 uv run mypy

pyproject.toml

@@ -54,3 +54,10 @@ packages = ["src/obelisk"]
 [tool.mypy]
 files = "src/obelisk"
 strict = true
+
+[tool.ruff]
+include = ["src/obelisk/**/*.py"]
+
+[tool.ruff.lint]
+select = ["E4", "E7", "E9", "F", "ASYNC", "S"]
+ignore = []

src/tests/asynchronous/client_test.py

@@ -5,7 +5,8 @@
 client_id = "682c6c46604b3b3be35429df"
 client_secret = "7136832d-01be-456a-a1fe-25c7f9e130c5"
 
-pytest_plugins = ('pytest_asyncio',)
+pytest_plugins = ("pytest_asyncio",)
+
 
 @pytest.mark.asyncio
 async def test_fetch_demo_igent():
@@ -15,7 +16,7 @@ async def test_fetch_demo_igent():
         metrics=["org.dyamand.types.common.Temperature::number"],
         from_timestamp=1740924034000,
         to_timestamp=1741100614258,
-        limit=2
+        limit=2,
     )
 
     assert len(result.items) == 2

src/tests/asynchronous/core_test.py

@@ -1,6 +1,11 @@
 from obelisk.asynchronous.core import QueryParams
 
+
 def test_query_param_serialize():
-    q = QueryParams(dataset="83989232", filter_="(metric=='smartphone.application::string')", dataType='string')
+    q = QueryParams(
+        dataset="83989232",
+        filter_="(metric=='smartphone.application::string')",
+        dataType="string",
+    )
     dump = q.to_dict()
     assert "filter" in dump

src/tests/sync/client_test.py

@@ -3,18 +3,20 @@
 client_id = "682c6c46604b3b3be35429df"
 client_secret = "7136832d-01be-456a-a1fe-25c7f9e130c5"
 
+
 def test_demo_igent_fetch():
     consumer = Obelisk(client=client_id, secret=client_secret)
     result = consumer.fetch_single_chunk(
         datasets=["612f6c39cbceda0ea9753d95"],
         metrics=["org.dyamand.types.common.Temperature::number"],
         from_timestamp=1740924034000,
         to_timestamp=1741100614258,
-        limit=2
+        limit=2,
     )
 
     assert len(result.items) == 2
 
+
 def test_two_instances():
     consumer_one = Obelisk(client=client_id, secret=client_secret)
     consumer_two = Obelisk(client=client_id, secret=client_secret)
@@ -23,14 +25,14 @@ def test_two_instances():
         metrics=["org.dyamand.types.common.Temperature::number"],
         from_timestamp=1740924034000,
         to_timestamp=1741100614258,
-        limit=2
+        limit=2,
     )
     result_two = consumer_two.fetch_single_chunk(
         datasets=["612f6c39cbceda0ea9753d95"],
         metrics=["org.dyamand.types.common.Temperature::number"],
         from_timestamp=1740924034000,
         to_timestamp=1741100614258,
-        limit=2
+        limit=2,
     )
     assert len(result_one.items) == 2
     assert len(result_two.items) == 2

src/tests/typetest/filter_test.py

@@ -4,16 +4,16 @@
 
 def test_basic_filter():
     test_dt = datetime.now()
-    f = Filter() \
+    f = (
+        Filter()
         .add_and(
-            Comparison.equal('source', 'test source'),
-        )\
-        .add_or(
-            Comparison.less('timestamp', test_dt)
-        )\
+            Comparison.equal("source", "test source"),
+        )
+        .add_or(Comparison.less("timestamp", test_dt))
         .add_or(
-            Comparison.is_in('metricType', ['number', 'number[]']),
+            Comparison.is_in("metricType", ["number", "number[]"]),
         )
+    )
 
     expected = f"((('source'=='test source'),'timestamp'<'{test_dt.isoformat()}'),'metricType'=in=('number', 'number[]'))"
     assert str(f) == expected