Integrate type checking with mypy

Adds mypy into the pre-commit hooks and CI,
and fixes some minor type errors

Author: Epse

.github/workflows/ci.yml

@@ -17,6 +17,7 @@ jobs:
       - run: uv python install python3.13
       - run: uv run ruff check src/obelisk/
       - run: uv run ruff format --check src/obelisk/
+      - run: uv run mypy src/obelisk/
   test:
     name: Run tests
     strategy:

hooks/pre-commit

@@ -10,4 +10,5 @@
 # Redirect output to stderr.
 exec 1>&2
 
-exec uv run ruff format --check src/obelisk/
+uv run ruff format --check src/obelisk/
+uv run mypy src/obelisk/

pyproject.toml

@@ -9,6 +9,7 @@ dependencies = [
     "pydantic>=2.10.6",
     "pytest>=8.3.5",
     "pytest-asyncio>=0.25.3",
+    "mypy>=1.18.2",
 ]
 authors = [
     { name="Stef Pletinck", email="[email protected]"},

src/__init__.py

@@ -225,6 +225,7 @@ def __init__(
         retry_strategy: RetryStrategy = NoRetryStrategy(),
     ) -> None:
         BaseClient.__init__(
+            self,
             client=client,
             secret=secret,
             retry_strategy=retry_strategy,

src/obelisk/asynchronous/core.py

@@ -46,7 +46,7 @@ def fetch_single_chunk(
         self,
         datasets: List[str],
         metrics: Optional[List[str]] = None,
-        fields: Optional[dict] = None,
+        fields: Optional[List[str]] = None,
         from_timestamp: Optional[int] = None,
         to_timestamp: Optional[int] = None,
         order_by: Optional[dict] = None,
@@ -116,7 +116,7 @@ def query(
         self,
         datasets: List[str],
         metrics: Optional[List[str]] = None,
-        fields: Optional[dict] = None,
+        fields: Optional[List[str]] = None,
         from_timestamp: Optional[int] = None,
         to_timestamp: Optional[int] = None,
         order_by: Optional[dict] = None,