🥵 add tests + cleanup

Author: jvdd

plotly_resampler/figure_resampler/figure_resampler.py

@@ -355,10 +355,14 @@ def show_dash(
             constructor via the ``show_dash_kwargs`` argument.
 
         """
+        available_modes = ["external", "inline", "inline_persistent", "jupyterlab"]
+        assert mode is None or mode in available_modes, (
+            f"mode must be one of {available_modes}"
+        )
         graph_properties = {} if graph_properties is None else graph_properties
         assert "config" not in graph_properties.keys()  # There is a param for config
         # 1. Construct the Dash app layout
-        if mode is "inline_persistent":
+        if mode == "inline_persistent":
             # Inline persistent mode: we display a static image of the figure when the
             # app is not reachable
             # Note: this is the "inline" behavior of JupyterDashInlinePersistentOutput

tests/test_figure_resampler.py

@@ -610,6 +610,25 @@ def test_stop_server_inline():
     proc.terminate()
 
 
+def test_stop_server_inline_persistent():
+    # mostly written to test the check_update_figure_dict whether the inline + height
+    # line option triggers
+    fr = FigureResampler(go.Figure())
+    n = 100_000
+    x = np.arange(n)
+    y = np.sin(x)
+    fr.add_trace(go.Scattergl(name="test"), hf_x=x, hf_y=y)
+    fr.update_layout(height=900)
+    fr.stop_server()
+    proc = multiprocessing.Process(target=fr.show_dash, kwargs=dict(mode="inline_persistent"))
+    proc.start()
+    import time
+
+    time.sleep(3)
+    fr.stop_server()
+    proc.terminate()
+
+
 def test_stop_server_external():
     fr = FigureResampler(go.Figure())
     n = 100_000