Skip to content

Commit 1510dc6

Browse files
committed
💨 removing todo & fixing small bug
1 parent e574fc0 commit 1510dc6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

plotly_resampler/figure_resampler/figure_resampler_interface.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,7 @@ def _get_current_graph(self) -> dict:
236236
"data": [
237237
{
238238
k: copy(trace[k])
239-
# TODO: why not "text" as well? -> we can use _hf_data_container.fields then
240-
for k in set(trace.keys()).difference({"x", "y", "hovertext"})
239+
for k in set(trace.keys()).difference({_hf_data_container.fields})
241240
}
242241
for trace in self._data
243242
],
@@ -613,7 +612,9 @@ def _parse_get_trace_props(
613612
hf_y = (
614613
trace["y"]
615614
if hasattr(trace, "y") and hf_y is None
616-
else hf_y.values if isinstance(hf_y, (pd.Series, pd.Index)) else hf_y
615+
else hf_y.values
616+
if isinstance(hf_y, (pd.Series, pd.Index))
617+
else hf_y
617618
)
618619
# NOTE: the if will not be triggered for a categorical series its values
619620
if not hasattr(hf_y, "dtype"):
@@ -1019,7 +1020,6 @@ def add_trace(
10191020
hf_properties = {}
10201021
for _, _, hf_param_name in DOWNSAMPLABLE_PROPERTIES:
10211022
if hf_param_name in trace_kwargs:
1022-
# TODO -> hf_param name
10231023
hf_properties[hf_param_name] = trace_kwargs.pop(hf_param_name)
10241024

10251025
# construct the hf_data_container

0 commit comments

Comments
 (0)