🖊️ review code

Author: jvdd

plotly_resampler/figure_resampler/jupyter_dash_persistent_inline_output.py

@@ -178,13 +178,23 @@ def run_app(
         port=8050,
         server_url=None,
     ):
-        """
-        :type app: dash.Dash
-        :param width: Width of app when displayed using mode="inline"
-        :param height: Height of app when displayed using mode="inline"
-        :param host: Host of the server
-        :param port: Port used by the server
-        :param server_url: Use if a custom url is required to display the app.
+        """Run the inline persistent dash app in the notebook.
+
+        Parameters
+        ----------
+        app : dash.Dash
+            A Dash application instance
+        width : str, optional
+            Width of app when displayed using mode="inline", by default "100%"
+        height : int, optional
+            Height of app when displayed using mode="inline", by default 650
+        host : str, optional
+            Host of the server, by default "127.0.0.1"
+        port : int, optional
+            Port used by the server, by default 8050
+        server_url : str, optional
+            Use if a custom url is required to display the app, by default None
+
         """
         # Terminate any existing server using this port
         old_server = JupyterDash._servers.get((host, port))
@@ -312,8 +322,6 @@ def wait_for_app():
                 _get_error()
                 raise err
 
-        print(dashboard_url)
-        print(alive_url)
         try:
             wait_for_app()
             self._display_inline_output(dashboard_url, width=width, height=height)

tests/utils.py

@@ -81,7 +81,9 @@ def construct_index(series: pd.Series, index_type: str) -> pd.Index:
 
 
 def decode_trace_bdata(data: dict | list):
-    """As from plotly>6.0.0, traces can be encoded as binary strings, we"""
+    """As from plotly>6.0.0, traces can be encoded as binary strings, we need to decode
+    them to get the actual data.
+    """
     if isinstance(data, dict) and "bdata" in data:
         bdata = data["bdata"]
         dtype = data["dtype"]