🙈 disable fancy-pants browser tests on non-linux platforms

Author: jvdd

tests/fr_selenium.py

@@ -11,7 +11,6 @@
 
 __author__ = "Jonas Van Der Donckt, Jeroen Van Der Donckt"
 
-import sys
 import json
 import time
 from typing import List, Union
@@ -20,21 +19,15 @@
 from seleniumwire.request import Request
 from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.common.by import By
-from selenium.webdriver.firefox.options import Options
 from selenium.webdriver.support import expected_conditions as EC
 from selenium.webdriver.support.ui import WebDriverWait
 
-
-def not_on_linux():
-    """Return True if the current platform is not Linux.
-    
-    Note: this will be used to add more waiting time to windows & mac os tests as 
-    - on these OS's serialization of the figure is necessary (to start the dash app in a 
-      multiprocessing.Process)
-      https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
-    - on linux, the browser (i.e., sending & getting requests) goes a lot faster
-    """
-    return not sys.platform.startswith("linux")
+# Note: this will be used to add more waiting time to windows & mac os tests as 
+# - on these OS's serialization of the figure is necessary (to start the dash app in a 
+#    multiprocessing.Process)
+#    https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods
+# - on linux, the browser (i.e., sending & getting requests) goes a lot faster
+from .utils import not_on_linux
 
 
 # https://www.blazemeter.com/blog/improve-your-selenium-webdriver-tests-with-pytest

tests/test_figure_resampler.py

@@ -17,6 +17,10 @@
 from plotly.subplots import make_subplots
 from plotly_resampler import FigureResampler, LTTB, EveryNthPoint
 
+# Note: this will be used to skip / alter behavior when running browser tests on 
+# non-linux platforms.
+from .utils import not_on_linux
+
 
 def test_add_trace_kwarg_space(float_series, bool_series, cat_series):
     # see: https://plotly.com/python/subplots/#custom-sized-subplot-with-subplot-titles
@@ -1087,13 +1091,17 @@ def check_data(fr: FigureResampler, min_v=0, max_v=nb_datapoints-1):
     # Even after updating the axes ranges
     check_data(f_pr)
 
+    if not_on_linux():
+        # TODO: eventually we should run this test on Windows & MacOS too
+        return
+
     f_pr.stop_server()
     proc = multiprocessing.Process(target=f_pr.show_dash, kwargs=dict(mode="external"))
     proc.start()
     try:
-        time.sleep(2)
+        time.sleep(1)
         driver.get(f"http://localhost:8050")
-        time.sleep(7)
+        time.sleep(3)
         # Get the data property from the front-end figure
         el = driver.find_element(by=By.ID, value="resample-figure")
         el = el.find_element(by=By.CLASS_NAME, value="js-plotly-plot")
@@ -1171,13 +1179,17 @@ def check_data(fr: FigureResampler, min_v=0, max_v=nb_datapoints-1):
     # Even after updating the axes ranges
     check_data(f_pr)
 
+    if not_on_linux():
+        # TODO: eventually we should run this test on Windows & MacOS too
+        return
+
     f_pr.stop_server()
     proc = multiprocessing.Process(target=f_pr.show_dash, kwargs=dict(mode="external"))
     proc.start()
     try:
-        time.sleep(2)
+        time.sleep(1)
         driver.get(f"http://localhost:8050")
-        time.sleep(7)
+        time.sleep(3)
         # Get the data & layout property from the front-end figure
         el = driver.find_element(by=By.ID, value="resample-figure")
         el = el.find_element(by=By.CLASS_NAME, value="js-plotly-plot")

tests/utils.py

@@ -0,0 +1,9 @@
+import sys
+
+def not_on_linux():
+    """Return True if the current platform is not Linux.
+    
+    This is to avoid / alter test bahavior for non-Linux (as browser testing gets
+    tricky on other platforms).
+    """
+    return not sys.platform.startswith("linux")