✨ improve try-except blocks, see #113

Author: jonasvdd

plotly_resampler/__init__.py

@@ -27,5 +27,5 @@
         from google.colab import output
 
         output.enable_custom_widget_manager()
-except ImportError:
+except (ImportError, ModuleNotFoundError):
     pass

plotly_resampler/aggregation/aggregators.py

@@ -19,7 +19,7 @@
 try:
     # The efficient c version of the LTTB algorithm
     from .algorithms.lttb_c import LTTB_core_c as LTTB_core
-except:
+except (ImportError, ModuleNotFoundError):
     import warnings
     warnings.warn("Could not import lttbc; will use a (slower) python alternative.")
     from .algorithms.lttb_py import LTTB_core_py as LTTB_core

plotly_resampler/figure_resampler/figure_resampler.py

@@ -17,7 +17,6 @@
 import base64
 import dash
 import plotly.graph_objects as go
-from dash import Dash
 from flask_cors import cross_origin
 from jupyter_dash import JupyterDash
 from plotly.basedatatypes import BaseFigure
@@ -320,7 +319,7 @@ def __init__(
                     self.data[idx].update(graph_dict["data"][idx])
 
         # The FigureResampler needs a dash app
-        self._app: JupyterDash | Dash | None = None
+        self._app: JupyterDash | dash.Dash | None = None
         self._port: int | None = None
         self._host: str | None = None
 

plotly_resampler/figure_resampler/figure_resampler_interface.py

@@ -697,7 +697,7 @@ def _parse_get_trace_props(
                 # not will be transformed to an array of ints (0, 1))
                 try:
                     hf_y = pd.to_numeric(hf_y, errors="raise")
-                except:
+                except ValueError:
                     hf_y = hf_y.astype("str")
 
             # orjson encoding doesn't like to encode with uint8 & uint16 dtype

plotly_resampler/figure_resampler/utils.py

@@ -4,9 +4,9 @@
 import pandas as pd
 
 from plotly.basedatatypes import BaseFigure
-try:
+try: # Fails when IPywidgets is not installed
     from plotly.basewidget import BaseFigureWidget
-except ImportError:
+except (ImportError, ModuleNotFoundError):
     BaseFigureWidget = None
 
 from typing import Any
@@ -32,7 +32,6 @@ def is_figure(figure: Any) -> bool:
     bool
         True if the figure is a plotly go.Figure or a FigureResampler.
     """
-
     return isinstance(figure, BaseFigure) and (not isinstance(figure, BaseFigureWidget))
 
 

plotly_resampler/registering.py

@@ -54,7 +54,7 @@ def _is_ipython_env():
         from IPython import get_ipython
 
         return "IPKernelApp" in get_ipython().config
-    except Exception:
+    except (ImportError, AttributeError):
         return False