Skip to content

Commit 80f8a06

Browse files
imichaelmoorejvddjonasvdd
authored
Remove locked werkzeug dependency due to CVE-2023-25577 (#174)
* Upgrade werkzeug to >=2.2.3 due to CVE-2023-25577 * 🖍️ fixing some variables / paths & adding docs * doc: code review Add link to issue #123 in FAQ Fixed wrong version of werkzeug. * chore: just remove werkzeug dependency --------- Co-authored-by: Jeroen Van Der Donckt <[email protected]> Co-authored-by: jonasvdd <[email protected]> Co-authored-by: Jeroen Van Der Donckt <[email protected]>
1 parent 8df65e1 commit 80f8a06

File tree

5 files changed

+734
-630
lines changed

5 files changed

+734
-630
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ documentation and [changelog.md](CHANGELOG.md).
112112
The current listing below gives you the provided steps to regenerate the documentation.
113113

114114
1. Make sure that your python env is active (e.g., by running `poetry shell`)
115-
2. Navigate to `sphinx/docs` and run from that directory:
115+
2. Navigate to `docs/sphinx` and run from that directory:
116116
```bash
117117
sphinx-autogen -o _autosummary && make clean html
118118
```

docs/sphinx/FAQ.rst

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,21 @@ The ``TraceUpdater`` class is a custom dash component that aids ``dcc.Graph`` co
6666

6767
For more information on how to use the trace-updater component together with the ``FigureResampler``, see our dash app `examples <https://github.com/predict-idlab/plotly-resampler/tree/main/examples>`_` and look at the `trace-updater <https://github.com/predict-idlab/trace-updater/blob/master/trace_updater/TraceUpdater.py>`_ its documentation.
6868

69+
.. raw:: html
70+
71+
</div>
72+
</details>
73+
<br>
74+
<details>
75+
<summary>
76+
<a><b>My <code>FigureResampler.show_dash</code> keeps hanging (indefinitely) with the error message:<br>&nbsp;&nbsp;&nbsp; <code>OSError: Port already in use</code></b></a>
77+
</summary>
78+
<div style="margin-left:1em">
79+
80+
Plotly-resampler its ``FigureResampler.show_dash`` method leverages the `jupyterdash <https://github.com/plotly/jupyter-dash>`_ toolkit to easily allow integration of dash apps in notebooks. However, there is a `known issue <https://github.com/plotly/jupyter-dash/pull/105>`_ with jupyterDash that causes the ``FigureResampler.show_dash`` method to hang when the port is already in use. In a future Pull-Request they will hopefully fix this issue. We internally track `this issue <https://github.com/predict-idlab/plotly-resampler/issues/123>` as well - please comment there if you want to provide feedback.
81+
82+
In the meantime, you can use the following workaround (if you do not care about the `Werkzeug security issue <https://github.com/predict-idlab/plotly-resampler/pull/174>`_): `pip install werkzeug==2.1.2`.
83+
6984
.. raw:: html
7085

7186
</div>
@@ -164,4 +179,4 @@ Furthermore combined with holoviews, datashader can also be employed in an inter
164179

165180
</div>
166181
</details>
167-
<br>
182+
<br>

docs/sphinx/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
# -- Project information -----------------------------------------------------
2121

2222
project = "plotly-resampler"
23-
copyright = "2022, Jonas Van Der Donckt"
23+
copyright = "2023, Jonas Van Der Donckt"
2424
author = "Jonas Van Der Donckt, Jeroen Van Der Donckt, Emiel Deprost"
2525

2626
# The full version, including alpha/beta/rc tags

0 commit comments

Comments
 (0)