Skip to content

Commit 87ce224

Browse files
committed
🏕️ add browser log checks to selenium tests
1 parent e89f12a commit 87ce224

File tree

2 files changed

+50
-8
lines changed

2 files changed

+50
-8
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def driver():
6565
options.add_argument("--remote-debugging-port=9222")
6666
driver = webdriver.Chrome(
6767
options=options,
68-
executable_path="/home/jeroen/chromedriver",
68+
# executable_path="/home/jeroen/chromedriver",
6969
desired_capabilities=d,
7070
)
7171
# driver = webdriver.Firefox(executable_path='/home/jonas/git/gIDLaB/plotly-dynamic-resampling/geckodriver')

tests/test_figure_resampler_selenium.py

Lines changed: 49 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,13 @@ def test_multiple_tz(driver, multiple_tz_figure):
6969
assert len(autoscale_requests) == 1
7070
assert autoscale_requests[0].response.status_code == 204
7171

72-
assert driver.get_log("browser") == [] # Check no errors in the browser
72+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
73+
for entry in driver.get_log("browser"):
74+
print(entry)
75+
if not entry["level"] == "INFO":
76+
# Only WebGL warnings are allowed
77+
assert entry["level"] == "warning"
78+
assert entry["message"].contains("WebGL")
7379
except Exception as e:
7480
raise e
7581
finally:
@@ -174,7 +180,13 @@ def test_basic_example_gui(driver, example_figure):
174180
n_updated_traces=5,
175181
)
176182

177-
assert driver.get_log("browser") == [] # Check no errors in the browser
183+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
184+
for entry in driver.get_log("browser"):
185+
print(entry)
186+
if not entry["level"] == "INFO":
187+
# Only WebGL warnings are allowed
188+
assert entry["level"] == "warning"
189+
assert entry["message"].contains("WebGL")
178190
except Exception as e:
179191
raise e
180192
finally:
@@ -282,7 +294,13 @@ def test_basic_example_gui_existing(driver, example_figure_fig):
282294
n_updated_traces=5,
283295
)
284296

285-
assert driver.get_log("browser") == [] # Check no errors in the browser
297+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
298+
for entry in driver.get_log("browser"):
299+
print(entry)
300+
if not entry["level"] == "INFO":
301+
# Only WebGL warnings are allowed
302+
assert entry["level"] == "warning"
303+
assert entry["message"].contains("WebGL")
286304
except Exception as e:
287305
raise e
288306
finally:
@@ -386,7 +404,13 @@ def test_gsr_gui(driver, gsr_figure):
386404
fr.reset_axes()
387405
time.sleep(0.2)
388406

389-
assert driver.get_log("browser") == [] # Check no errors in the browser
407+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
408+
for entry in driver.get_log("browser"):
409+
print(entry)
410+
if not entry["level"] == "INFO":
411+
# Only WebGL warnings are allowed
412+
assert entry["level"] == "warning"
413+
assert entry["message"].contains("WebGL")
390414
except Exception as e:
391415
raise e
392416
finally:
@@ -461,7 +485,13 @@ def test_cat_gui(driver, cat_series_box_hist_figure):
461485
n_updated_traces=1,
462486
)
463487

464-
assert driver.get_log("browser") == [] # Check no errors in the browser
488+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
489+
for entry in driver.get_log("browser"):
490+
print(entry)
491+
if not entry["level"] == "INFO":
492+
# Only WebGL warnings are allowed
493+
assert entry["level"] == "warning"
494+
assert entry["message"].contains("WebGL")
465495
except Exception as e:
466496
raise e
467497
finally:
@@ -537,7 +567,13 @@ def test_shared_hover_gui(driver, shared_hover_figure):
537567
assert len(autoscale_requests) == 1
538568
assert autoscale_requests[0].response.status_code == 204
539569

540-
assert driver.get_log("browser") == [] # Check no errors in the browser
570+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
571+
for entry in driver.get_log("browser"):
572+
print(entry)
573+
if not entry["level"] == "INFO":
574+
# Only WebGL warnings are allowed
575+
assert entry["level"] == "warning"
576+
assert entry["message"].contains("WebGL")
541577
except Exception as e:
542578
raise e
543579
finally:
@@ -610,7 +646,13 @@ def test_multi_trace_go_figure(driver, multi_trace_go_figure):
610646
assert len(autoscale_requests) == 1
611647
assert autoscale_requests[0].response.status_code == 204
612648

613-
assert driver.get_log("browser") == [] # Check no errors in the browser
649+
if len(driver.get_log("browser")) > 0: # Check no errors in the browser
650+
for entry in driver.get_log("browser"):
651+
print(entry)
652+
if not entry["level"] == "INFO":
653+
# Only WebGL warnings are allowed
654+
assert entry["level"] == "warning"
655+
assert entry["message"].contains("WebGL")
614656
except Exception as e:
615657
raise e
616658
finally:

0 commit comments

Comments
 (0)