Skip to content

Commit d1c6046

Browse files
committed
🚆 improve test cov
1 parent f4bce66 commit d1c6046

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/test_figure_resampler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55

66
import pytest
7+
import time
78
import numpy as np
89
import pandas as pd
910
import multiprocessing
@@ -603,7 +604,6 @@ def test_stop_server_inline():
603604
fr.stop_server()
604605
proc = multiprocessing.Process(target=fr.show_dash, kwargs=dict(mode="inline"))
605606
proc.start()
606-
import time
607607

608608
time.sleep(3)
609609
fr.stop_server()
@@ -622,7 +622,6 @@ def test_stop_server_inline_persistent():
622622
fr.stop_server()
623623
proc = multiprocessing.Process(target=fr.show_dash, kwargs=dict(mode="inline_persistent"))
624624
proc.start()
625-
import time
626625

627626
time.sleep(3)
628627
fr.stop_server()
@@ -658,8 +657,10 @@ def test_manual_jupyterdashpersistentinline():
658657
]
659658
)
660659

661-
# call the method
660+
# call the method (as it would normally be called)
662661
app._display_in_jupyter(f"", port="", mode="inline", width='100%', height=500)
662+
# call with a different mode (as it normally never would be called)
663+
app._display_in_jupyter(f"", port="", mode="external", width='100%', height=500)
663664

664665

665666
def test_stop_server_external():
@@ -672,7 +673,6 @@ def test_stop_server_external():
672673
fr.stop_server()
673674
proc = multiprocessing.Process(target=fr.show_dash, kwargs=dict(mode="external"))
674675
proc.start()
675-
import time
676676

677677
time.sleep(3)
678678
fr.stop_server()

0 commit comments

Comments
 (0)