fix: deprecate [build-dependencies] and [host-dependencies] (#4767)

Author: Hofer-Julian

crates/pixi_manifest/src/toml/feature.rs

@@ -15,6 +15,7 @@ use crate::{
         task::TomlTask,
     },
     utils::{PixiSpanned, package_map::UniquePackageMap},
+    warning::Deprecation,
     workspace::ChannelPriority,
 };
 use pixi_pypi_spec::{PixiPypiSpec, PypiPackageName};
@@ -137,8 +138,33 @@ impl<'de> toml_span::Deserialize<'de> for TomlFeature {
             .map(TomlIndexMap::into_inner)
             .unwrap_or_default();
         let dependencies = th.optional("dependencies");
-        let host_dependencies = th.optional("host-dependencies");
-        let build_dependencies = th.optional("build-dependencies");
+        let host_dependencies: Option<Spanned<UniquePackageMap>> = th.optional("host-dependencies");
+        if let Some(host_dependencies) = &host_dependencies {
+            warnings.push(
+                Deprecation::renamed_field(
+                    "host-dependencies",
+                    "dependencies",
+                    host_dependencies.span,
+                )
+                .into(),
+            );
+        }
+        let host_dependencies = host_dependencies.map(From::from);
+
+        let build_dependencies: Option<Spanned<UniquePackageMap>> =
+            th.optional("build-dependencies");
+        if let Some(build_dependencies) = &build_dependencies {
+            warnings.push(
+                Deprecation::renamed_field(
+                    "build-dependencies",
+                    "dependencies",
+                    build_dependencies.span,
+                )
+                .into(),
+            );
+        }
+        let build_dependencies = build_dependencies.map(From::from);
+
         let pypi_dependencies = th
             .optional::<TomlIndexMap<_, _>>("pypi-dependencies")
             .map(TomlIndexMap::into_inner);
@@ -216,4 +242,64 @@ mod test {
         "#,
         ));
     }
+
+    #[test]
+    fn test_host_dependencies_deprecation_warning() {
+        assert_snapshot!(
+            expect_parse_warnings(
+            r#"
+        [workspace]
+        name = "test"
+        channels = []
+        platforms = ['linux-64']
+
+        [feature.foo.host-dependencies]
+        foo = "*"
+
+        [environments]
+        dev = ["foo"]
+        "#,
+            ),
+            @r#"
+         ⚠ The `host-dependencies` field is deprecated. Use `dependencies` instead.
+          ╭─[pixi.toml:7:9]
+        6 │
+        7 │ ╭─▶         [feature.foo.host-dependencies]
+        8 │ ├─▶         foo = "*"
+          · ╰──── replace this with 'dependencies'
+        9 │
+          ╰────
+        "#
+        );
+    }
+
+    #[test]
+    fn test_build_dependencies_deprecation_warning() {
+        assert_snapshot!(
+            expect_parse_warnings(
+            r#"
+        [workspace]
+        name = "test"
+        channels = []
+        platforms = ['linux-64']
+
+        [feature.foo.build-dependencies]
+        bar = "*"
+
+        [environments]
+        dev = ["foo"]
+        "#,
+            ),
+            @r#"
+         ⚠ The `build-dependencies` field is deprecated. Use `dependencies` instead.
+          ╭─[pixi.toml:7:9]
+        6 │
+        7 │ ╭─▶         [feature.foo.build-dependencies]
+        8 │ ├─▶         bar = "*"
+          · ╰──── replace this with 'dependencies'
+        9 │
+          ╰────
+        "#
+        );
+    }
 }

crates/pixi_manifest/src/toml/manifest.rs

@@ -486,8 +486,34 @@ impl<'de> toml_span::Deserialize<'de> for TomlManifest {
             .map(TomlWith::into_inner);
 
         let dependencies = th.optional("dependencies");
-        let host_dependencies = th.optional("host-dependencies");
-        let build_dependencies = th.optional("build-dependencies");
+
+        let host_dependencies: Option<Spanned<UniquePackageMap>> = th.optional("host-dependencies");
+        if let Some(host_dependencies) = &host_dependencies {
+            warnings.push(
+                Deprecation::renamed_field(
+                    "host-dependencies",
+                    "dependencies",
+                    host_dependencies.span,
+                )
+                .into(),
+            );
+        }
+        let host_dependencies = host_dependencies.map(From::from);
+
+        let build_dependencies: Option<Spanned<UniquePackageMap>> =
+            th.optional("build-dependencies");
+        if let Some(build_dependencies) = &build_dependencies {
+            warnings.push(
+                Deprecation::renamed_field(
+                    "build-dependencies",
+                    "dependencies",
+                    build_dependencies.span,
+                )
+                .into(),
+            );
+        }
+        let build_dependencies = build_dependencies.map(From::from);
+
         let pypi_dependencies = th
             .optional::<TomlWith<_, PixiSpanned<TomlIndexMap<_, Same>>>>("pypi-dependencies")
             .map(TomlWith::into_inner);
@@ -788,6 +814,60 @@ mod test {
         ));
     }
 
+    #[test]
+    fn test_host_dependencies_deprecation_warning() {
+        assert_snapshot!(
+            expect_parse_warnings(
+            r#"
+        [workspace]
+        name = "test"
+        channels = []
+        platforms = ['linux-64']
+
+        [host-dependencies]
+        foo = "*"
+        "#,
+            ),
+            @r#"
+         ⚠ The `host-dependencies` field is deprecated. Use `dependencies` instead.
+          ╭─[pixi.toml:7:9]
+        6 │
+        7 │ ╭─▶         [host-dependencies]
+        8 │ ├─▶         foo = "*"
+          · ╰──── replace this with 'dependencies'
+        9 │
+          ╰────
+        "#
+        );
+    }
+
+    #[test]
+    fn test_build_dependencies_deprecation_warning() {
+        assert_snapshot!(
+            expect_parse_warnings(
+            r#"
+        [workspace]
+        name = "test"
+        channels = []
+        platforms = ['linux-64']
+
+        [build-dependencies]
+        bar = "*"
+        "#,
+            ),
+            @r#"
+         ⚠ The `build-dependencies` field is deprecated. Use `dependencies` instead.
+          ╭─[pixi.toml:7:9]
+        6 │
+        7 │ ╭─▶         [build-dependencies]
+        8 │ ├─▶         bar = "*"
+          · ╰──── replace this with 'dependencies'
+        9 │
+          ╰────
+        "#
+        );
+    }
+
     #[test]
     fn test_unused_features() {
         assert_snapshot!(expect_parse_warnings(