Skip to content

Commit 4fc74d1

Browse files
wolfvpavelzw
andauthored
fix: change --force-path-style to --addressing-style in test and docs (#1913)
Co-authored-by: Pavel Zwerschke <[email protected]>
1 parent 1adca55 commit 4fc74d1

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

docs/authentication_and_upload.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,15 +159,17 @@ rattler-build upload anaconda -o <your_username> -c <label> <package_files>
159159
### S3
160160

161161
To upload to an S3 bucket, you need to set access key ID, secret access key and (optionally) a session token.
162-
If not using `rattler-build auth login s3://my-bucket --s3-access-key-id <access-key-id> --s3-secret-access-key <secret-access-key> --s3-session-token <session-token>`, you can set the corresponding `AWS_*` environment variables (even if not using AWS S3).
162+
If not using `rattler-build auth login s3://my-bucket --s3-access-key-id <access-key-id> --s3-secret-access-key <secret-access-key> --s3-session-token <session-token>`, you can set the corresponding `S3_*` environment variables.
163+
163164
For instance, the following example uploads to a Cloudflare R2 S3 bucket:
164165

165166
```bash
166-
export AWS_ACCESS_KEY_ID=<your_access_key_id>
167-
export AWS_SECRET_ACCESS_KEY=<your_secret_access_key>
167+
export S3_ACCESS_KEY_ID=<your_access_key_id>
168+
export S3_SECRET_ACCESS_KEY=<your_secret_access_key>
169+
168170
rattler-build upload s3 \
169171
--channel s3://my-bucket/my-channel \
170172
--region auto \
171173
--endpoint-url https://xyz.r2.cloudflarestorage.com \
172-
--force-path-style
174+
--addressing-style path
173175
```

test/end-to-end/test_simple.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,8 @@ def test_s3_minio_upload(
484484
s3_config.region,
485485
"--endpoint-url",
486486
s3_config.endpoint_url,
487-
"--force-path-style",
487+
"--addressing-style",
488+
"path",
488489
str(get_package(tmp_path, "globtest")),
489490
]
490491
rattler_build(*cmd)

0 commit comments

Comments
 (0)