-
Notifications
You must be signed in to change notification settings - Fork 23
Description
When resolving botocore and urllib it can happen that rip chooses the highest version of urllib3 (2.2) and then tries to resolve botocore.
However, botocore has an upper bound for urllib >=1.5,<2.1 or something like that.
Now the logical thing to do would be to lock in botocore and try older (compatible) versions of urllib3. Instead, rip tries all versions of botocore in existence (which are many) until it hits an outdated, broken sdist and crashes :'(
I think we should have some logic that implicitly adds the upper bound of any higher version to the lower versions and therefore dismisses urllib3 2.2 for any version of botocore (because it doesn't really make sense that a previous version of botocore would be compatible with a later urllib3).
Metadata
Metadata
Assignees
Labels
Type
Projects
Status