Skip to content

Strange Boolean Ternary #170

@ncfrey

Description

@ncfrey

Feedback: use_flash_attn: bool | None = None is a tri-state Boolean.

  • Replace the tri-state Boolean with a clearer alternative:
    • Either make it strictly a bool with a well-defined default (True or False),
    • Or use an Enum like FlashAttentionOption = Enum("FlashAttentionOption", ["AUTO", "ENABLED", "DISABLED"]).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions