Skip to content

Confusing forward Type Signature #172

@ncfrey

Description

@ncfrey

Feedback: Forward signature is neither clearly static nor dynamic.

  • Refine forward() method signature:
    • Decide between static: forward(self, input_ids: Tensor, attention_mask: Tensor)
    • Or dynamic: forward(self, inputs: Sequence[Tensor])
  • Use typing annotations and docstrings to clarify expected inputs and outputs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions