-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Feedback: Forward signature is neither clearly static nor dynamic.
- Refine
forward()method signature:- Decide between static:
forward(self, input_ids: Tensor, attention_mask: Tensor) - Or dynamic:
forward(self, inputs: Sequence[Tensor])
- Decide between static:
- Use typing annotations and docstrings to clarify expected inputs and outputs.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed