Fix review comments and adding newline to the end of each file

PingLiuPing · PingLiuPing · commit 9edb1742f145 · 2025-04-24T20:29:37.000+01:00
diff --git a/benchmarks/tpch-load/create-table/customer.sql b/benchmarks/tpch-load/create-table/customer.sql
@@ -8,4 +8,4 @@ CREATE TABLE customer (
     acctbal     DECIMAL(12,2) NOT NULL,
     mktsegment  VARCHAR(10) NOT NULL,
     comment     VARCHAR(117) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/lineitem.sql b/benchmarks/tpch-load/create-table/lineitem.sql
@@ -16,4 +16,4 @@ CREATE TABLE lineitem (
     shipinstruct  VARCHAR(25) NOT NULL,
     shipmode      VARCHAR(10) NOT NULL,
     comment       VARCHAR(44) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/nation.sql b/benchmarks/tpch-load/create-table/nation.sql
@@ -4,4 +4,4 @@ CREATE TABLE nation (
     name        VARCHAR(25) NOT NULL,
     regionkey   BIGINT NOT NULL,
     comment     VARCHAR(152) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/orders.sql b/benchmarks/tpch-load/create-table/orders.sql
@@ -9,4 +9,4 @@ CREATE TABLE orders (
     clerk          VARCHAR(15) NOT NULL,
     shippriority   BIGINT NOT NULL,
     comment        VARCHAR(79) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/part.sql b/benchmarks/tpch-load/create-table/part.sql
@@ -9,4 +9,4 @@ CREATE TABLE part (
     container   VARCHAR(10) NOT NULL,
     retailprice DECIMAL(12,2) NOT NULL,
     comment     VARCHAR(23) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/partsupp.sql b/benchmarks/tpch-load/create-table/partsupp.sql
@@ -5,4 +5,4 @@ CREATE TABLE partsupp (
     availqty   BIGINT NOT NULL,
     supplycost DECIMAL(12,2) NOT NULL,
     comment    VARCHAR(199) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/region.sql b/benchmarks/tpch-load/create-table/region.sql
@@ -3,4 +3,4 @@ CREATE TABLE region (
     regionkey   BIGINT NOT NULL,
     name        VARCHAR(25) NOT NULL,
     comment     VARCHAR(152) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/create-table/supplier.sql b/benchmarks/tpch-load/create-table/supplier.sql
@@ -7,4 +7,4 @@ CREATE TABLE supplier (
     phone       VARCHAR(15) NOT NULL,
     acctbal     DECIMAL(12,2) NOT NULL,
     comment     VARCHAR(101) NOT NULL
-) WITH (format = 'PARQUET');
+) WITH (format = 'PARQUET');
diff --git a/benchmarks/tpch-load/drop-table/customer.sql b/benchmarks/tpch-load/drop-table/customer.sql
@@ -1 +1 @@
-DROP TABLE customer;
+DROP TABLE customer;
diff --git a/benchmarks/tpch-load/drop-table/lineitem.sql b/benchmarks/tpch-load/drop-table/lineitem.sql
@@ -1 +1 @@
-DROP TABLE lineitem;
+DROP TABLE lineitem;
diff --git a/benchmarks/tpch-load/drop-table/nation.sql b/benchmarks/tpch-load/drop-table/nation.sql
@@ -1 +1 @@
-DROP TABLE nation;
+DROP TABLE nation;
diff --git a/benchmarks/tpch-load/drop-table/orders.sql b/benchmarks/tpch-load/drop-table/orders.sql
@@ -1 +1 @@
-DROP TABLE orders;
+DROP TABLE orders;
diff --git a/benchmarks/tpch-load/drop-table/part.sql b/benchmarks/tpch-load/drop-table/part.sql
@@ -1 +1 @@
-DROP TABLE part;
+DROP TABLE part;
diff --git a/benchmarks/tpch-load/drop-table/partsupp.sql b/benchmarks/tpch-load/drop-table/partsupp.sql
@@ -1 +1 @@
-DROP TABLE partsupp;
+DROP TABLE partsupp;
diff --git a/benchmarks/tpch-load/drop-table/region.sql b/benchmarks/tpch-load/drop-table/region.sql
@@ -1 +1 @@
-DROP TABLE region;
+DROP TABLE region;
diff --git a/benchmarks/tpch-load/drop-table/supplier.sql b/benchmarks/tpch-load/drop-table/supplier.sql
@@ -1 +1 @@
-DROP TABLE supplier;
+DROP TABLE supplier;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/customer_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/customer_sf100.sql
@@ -9,4 +9,4 @@ SELECT
     CAST(acctbal AS DECIMAL(12,2)),
     CAST(mktsegment AS VARCHAR(10)),
     CAST(comment AS VARCHAR(117))
-FROM tpch.sf100.customer;
+FROM tpch.sf100.customer;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/lineitem_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/lineitem_sf100.sql
@@ -17,4 +17,4 @@ SELECT
     CAST(shipinstruct AS VARCHAR(25)),
     CAST(shipmode AS VARCHAR(10)),
     CAST(comment AS VARCHAR(44))
-FROM tpch.sf100.lineitem;
+FROM tpch.sf100.lineitem;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/nation_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/nation_sf100.sql
@@ -5,4 +5,4 @@ SELECT
     CAST(name AS VARCHAR(25)),
     regionkey,
     CAST(comment AS VARCHAR(152))
-FROM tpch.sf100.nation;
+FROM tpch.sf100.nation;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/orders_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/orders_sf100.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(clerk AS VARCHAR(15)),
     shippriority,
     CAST(comment AS VARCHAR(79))
-FROM tpch.sf100.orders;
+FROM tpch.sf100.orders;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/part_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/part_sf100.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(container AS VARCHAR(10)),
     CAST(retailprice AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(23))
-FROM tpch.sf100.part;
+FROM tpch.sf100.part;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/partsupp_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/partsupp_sf100.sql
@@ -6,4 +6,4 @@ SELECT
     availqty,
     CAST(supplycost AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(199))
-FROM tpch.sf100.partsupp;
+FROM tpch.sf100.partsupp;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/region_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/region_sf100.sql
@@ -4,4 +4,4 @@ SELECT
     regionkey,
     CAST(name AS VARCHAR(25)),
     CAST(comment AS VARCHAR(152))
-FROM tpch.sf100.region;
+FROM tpch.sf100.region;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-100/supplier_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-100/supplier_sf100.sql
@@ -8,4 +8,4 @@ SELECT
     CAST(phone AS VARCHAR(15)),
     CAST(acctbal AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(101))
-FROM tpch.sf100.supplier;
+FROM tpch.sf100.supplier;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/customer_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/customer_sf1000.sql
@@ -9,4 +9,4 @@ SELECT
     CAST(acctbal AS DECIMAL(12,2)),
     CAST(mktsegment AS VARCHAR(10)),
     CAST(comment AS VARCHAR(117))
-FROM tpch.sf1000.customer;
+FROM tpch.sf1000.customer;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/lineitem_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/lineitem_sf1000.sql
@@ -17,4 +17,4 @@ SELECT
     CAST(shipinstruct AS VARCHAR(25)),
     CAST(shipmode AS VARCHAR(10)),
     CAST(comment AS VARCHAR(44))
-FROM tpch.sf1000.lineitem;
+FROM tpch.sf1000.lineitem;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/nation_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/nation_sf1000.sql
@@ -5,4 +5,4 @@ SELECT
     CAST(name AS VARCHAR(25)),
     regionkey,
     CAST(comment AS VARCHAR(152))
-FROM tpch.sf1000.nation;
+FROM tpch.sf1000.nation;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/orders_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/orders_sf1000.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(clerk AS VARCHAR(15)),
     shippriority,
     CAST(comment AS VARCHAR(79))
-FROM tpch.sf1000.orders;
+FROM tpch.sf1000.orders;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/part_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/part_sf1000.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(container AS VARCHAR(10)),
     CAST(retailprice AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(23))
-FROM tpch.sf1000.part;
+FROM tpch.sf1000.part;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/partsupp_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/partsupp_sf1000.sql
@@ -6,4 +6,4 @@ SELECT
     availqty,
     CAST(supplycost AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(199))
-FROM tpch.sf1000.partsupp;
+FROM tpch.sf1000.partsupp;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/region_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/region_sf1000.sql
@@ -4,4 +4,4 @@ SELECT
     regionkey,
     CAST(name AS VARCHAR(25)),
     CAST(comment AS VARCHAR(152))
-FROM tpch.sf1000.region;
+FROM tpch.sf1000.region;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/supplier_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-j-1000/supplier_sf1000.sql
@@ -8,4 +8,4 @@ SELECT
     CAST(phone AS VARCHAR(15)),
     CAST(acctbal AS DECIMAL(12,2)),
     CAST(comment AS VARCHAR(101))
-FROM tpch.sf1000.supplier;
+FROM tpch.sf1000.supplier;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/customer_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/customer_sf100.sql
@@ -9,4 +9,4 @@ SELECT
     CAST(c_acctbal AS DECIMAL(12,2)),
     CAST(c_mktsegment AS VARCHAR(10)),
     CAST(c_comment AS VARCHAR(117))
-FROM tpch.sf100.customer;
+FROM tpch.sf100.customer;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/lineitem_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/lineitem_sf100.sql
@@ -17,4 +17,4 @@ SELECT
     CAST(l_shipinstruct AS VARCHAR(25)),
     CAST(l_shipmode AS VARCHAR(10)),
     CAST(l_comment AS VARCHAR(44))
-FROM tpch.sf100.lineitem;
+FROM tpch.sf100.lineitem;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/nation_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/nation_sf100.sql
@@ -5,4 +5,4 @@ SELECT
     CAST(n_name AS VARCHAR(25)),
     n_regionkey,
     CAST(n_comment AS VARCHAR(152))
-FROM tpch.sf100.nation;
+FROM tpch.sf100.nation;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/orders_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/orders_sf100.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(o_clerk AS VARCHAR(15)),
     o_shippriority,
     CAST(o_comment AS VARCHAR(79))
-FROM tpch.sf100.orders;
+FROM tpch.sf100.orders;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/part_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/part_sf100.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(p_container AS VARCHAR(10)),
     CAST(p_retailprice AS DECIMAL(12,2)),
     CAST(p_comment AS VARCHAR(23))
-FROM tpch.sf100.part;
+FROM tpch.sf100.part;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/partsupp_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/partsupp_sf100.sql
@@ -6,4 +6,4 @@ SELECT
     ps_availqty,
     CAST(ps_supplycost AS DECIMAL(12,2)),
     CAST(ps_comment AS VARCHAR(199))
-FROM tpch.sf100.partsupp;
+FROM tpch.sf100.partsupp;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/region_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/region_sf100.sql
@@ -4,4 +4,4 @@ SELECT
     r_regionkey,
     CAST(r_name AS VARCHAR(25)),
     CAST(r_comment AS VARCHAR(152))
-FROM tpch.sf100.region;
+FROM tpch.sf100.region;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-100/supplier_sf100.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-100/supplier_sf100.sql
@@ -8,4 +8,4 @@ SELECT
     CAST(s_phone AS VARCHAR(15)),
     CAST(s_acctbal AS DECIMAL(12,2)),
     CAST(s_comment AS VARCHAR(101))
-FROM tpch.sf100.supplier;
+FROM tpch.sf100.supplier;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/customer_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/customer_sf1000.sql
@@ -9,4 +9,4 @@ SELECT
     CAST(c_acctbal AS DECIMAL(12,2)),
     CAST(c_mktsegment AS VARCHAR(10)),
     CAST(c_comment AS VARCHAR(117))
-FROM tpch.sf1000.customer;
+FROM tpch.sf1000.customer;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/lineitem_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/lineitem_sf1000.sql
@@ -17,4 +17,4 @@ SELECT
     CAST(l_shipinstruct AS VARCHAR(25)),
     CAST(l_shipmode AS VARCHAR(10)),
     CAST(l_comment AS VARCHAR(44))
-FROM tpch.sf1000.lineitem;
+FROM tpch.sf1000.lineitem;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/nation_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/nation_sf1000.sql
@@ -5,4 +5,4 @@ SELECT
     CAST(n_name AS VARCHAR(25)),
     n_regionkey,
     CAST(n_comment AS VARCHAR(152))
-FROM tpch.sf1000.nation;
+FROM tpch.sf1000.nation;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/orders_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/orders_sf1000.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(o_clerk AS VARCHAR(15)),
     o_shippriority,
     CAST(o_comment AS VARCHAR(79))
-FROM tpch.sf1000.orders;
+FROM tpch.sf1000.orders;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/part_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/part_sf1000.sql
@@ -10,4 +10,4 @@ SELECT
     CAST(p_container AS VARCHAR(10)),
     CAST(p_retailprice AS DECIMAL(12,2)),
     CAST(p_comment AS VARCHAR(23))
-FROM tpch.sf1000.part;
+FROM tpch.sf1000.part;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/partsupp_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/partsupp_sf1000.sql
@@ -6,4 +6,4 @@ SELECT
     ps_availqty,
     CAST(ps_supplycost AS DECIMAL(12,2)),
     CAST(ps_comment AS VARCHAR(199))
-FROM tpch.sf1000.partsupp;
+FROM tpch.sf1000.partsupp;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/region_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/region_sf1000.sql
@@ -4,4 +4,4 @@ SELECT
     r_regionkey,
     CAST(r_name AS VARCHAR(25)),
     CAST(r_comment AS VARCHAR(152))
-FROM tpch.sf1000.region;
+FROM tpch.sf1000.region;
diff --git a/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/supplier_sf1000.sql b/benchmarks/tpch-load/from-tpch-to-parquet-n-1000/supplier_sf1000.sql
@@ -8,4 +8,4 @@ SELECT
     CAST(s_phone AS VARCHAR(15)),
     CAST(s_acctbal AS DECIMAL(12,2)),
     CAST(s_comment AS VARCHAR(101))
-FROM tpch.sf1000.supplier;
+FROM tpch.sf1000.supplier;
diff --git a/benchmarks/tpch-load/hive_sf100.json b/benchmarks/tpch-load/hive_sf100.json
@@ -2,4 +2,4 @@
   "description": "Specifies the schema for TPCH scale factor 100 GB.",
   "catalog": "hive",
   "schema": "load_tpch_sf100_parquet"
-}
+}
diff --git a/benchmarks/tpch-load/hive_sf1000.json b/benchmarks/tpch-load/hive_sf1000.json
@@ -2,4 +2,4 @@
   "description": "Specifies the schema for TPCH scale factor 1000 GB.",
   "catalog": "hive",
   "schema": "load_tpch_sf1000_parquet"
-}
+}
diff --git a/benchmarks/tpch-load/iceberg_sf100.json b/benchmarks/tpch-load/iceberg_sf100.json
@@ -2,4 +2,4 @@
   "description": "Specifies the schema for TPCH scale factor 100 GB.",
   "catalog": "iceberg",
   "schema": "load_tpch_sf100_parquet"
-}
+}
diff --git a/benchmarks/tpch-load/iceberg_sf1000.json b/benchmarks/tpch-load/iceberg_sf1000.json
@@ -2,4 +2,4 @@
   "description": "Specifies the schema for TPCH scale factor 1000 GB.",
   "catalog": "iceberg",
   "schema": "load_tpch_sf1000_parquet"
-}
+}
diff --git a/benchmarks/tpch-load/schema/drop_sf100.sql b/benchmarks/tpch-load/schema/drop_sf100.sql
@@ -1 +1 @@
-drop schema load_tpch_sf100_parquet;
+drop schema load_tpch_sf100_parquet;
diff --git a/benchmarks/tpch-load/schema/drop_sf1000.sql b/benchmarks/tpch-load/schema/drop_sf1000.sql
@@ -1 +1 @@
-drop schema load_tpch_sf1000_parquet;
+drop schema load_tpch_sf1000_parquet;

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-DROP TABLE customer;`
	`1`	`+DROP TABLE customer;`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-DROP TABLE lineitem;`
	`1`	`+DROP TABLE lineitem;`