[Address Comment] Fix little things and typos

Author: hantangwangd

presto-main-base/src/main/java/com/facebook/presto/execution/CallTask.java

@@ -123,13 +123,6 @@ public ListenableFuture<?> execute(Call call, TransactionManager transactionMana
         return immediateFuture(null);
     }
 
-    public static Object toTypeObjectValue(Session session, Type type, Object value)
-    {
-        BlockBuilder blockBuilder = type.createBlockBuilder(null, 1);
-        writeNativeValue(type, blockBuilder, value);
-        return type.getObjectValue(session.getSqlFunctionProperties(), blockBuilder, 0);
-    }
-
     public static Object[] extractParameterValuesInOrder(Call call, Procedure procedure, Metadata metadata, Session session, Map<NodeRef<Parameter>, Expression> parameterLookup)
     {
         // map declared argument names to positions
@@ -204,4 +197,11 @@ else if (i < procedure.getArguments().size()) {
 
         return values;
     }
+
+    private static Object toTypeObjectValue(Session session, Type type, Object value)
+    {
+        BlockBuilder blockBuilder = type.createBlockBuilder(null, 1);
+        writeNativeValue(type, blockBuilder, value);
+        return type.getObjectValue(session.getSqlFunctionProperties(), blockBuilder, 0);
+    }
 }

presto-main-base/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java

@@ -258,7 +258,6 @@
 import static com.facebook.presto.spi.function.FunctionKind.WINDOW;
 import static com.facebook.presto.spi.function.table.DescriptorArgument.NULL_DESCRIPTOR;
 import static com.facebook.presto.spi.function.table.ReturnTypeSpecification.GenericTable.GENERIC_TABLE;
-import static com.facebook.presto.spi.procedure.DistributedProcedure.DistributedProcedureType.TABLE_DATA_REWRITE;
 import static com.facebook.presto.sql.MaterializedViewUtils.buildOwnerSession;
 import static com.facebook.presto.sql.MaterializedViewUtils.generateBaseTablePredicates;
 import static com.facebook.presto.sql.MaterializedViewUtils.generateFalsePredicates;
@@ -1211,7 +1210,7 @@ protected Scope visitCall(Call call, Optional<Scope> scope)
             Object[] values = extractParameterValuesInOrder(call, procedure, metadata, session, analysis.getParameters());
 
             analysis.setUpdateType("CALL");
-            analysis.setDistributedProcedureType(Optional.of(TABLE_DATA_REWRITE));
+            analysis.setDistributedProcedureType(Optional.of(procedure.getType()));
             analysis.setProcedureArguments(Optional.of(values));
             switch (procedure.getType()) {
                 case TABLE_DATA_REWRITE:

presto-main-base/src/main/java/com/facebook/presto/sql/planner/optimizations/SymbolMapper.java

@@ -53,7 +53,6 @@
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
-import java.util.stream.Collectors;
 
 import static com.facebook.presto.spi.StandardWarningCode.MULTIPLE_ORDER_BY;
 import static com.facebook.presto.spi.plan.AggregationNode.groupingSets;
@@ -282,7 +281,7 @@ public CallDistributedProcedureNode map(CallDistributedProcedureNode node, PlanN
                 node.getFragmentVariable(),
                 node.getTableCommitContextVariable(),
                 columns,
-                columns.stream().map(VariableReferenceExpression::getName).collect(Collectors.toList()),
+                columns.stream().map(VariableReferenceExpression::getName).collect(toImmutableList()),
                 notNullColumnVariables,
                 node.getPartitioningScheme().map(partitioningScheme -> canonicalize(partitioningScheme, source)));
     }

presto-spi/src/main/java/com/facebook/presto/spi/procedure/DistributedProcedure.java

@@ -37,8 +37,8 @@ protected DistributedProcedure(DistributedProcedureType type, String schema, Str
     {
         super(schema, name, arguments);
         this.type = requireNonNull(type, "distributed procedure type is null");
-        this.beginCallDistributedProcedure = requireNonNull(beginCallDistributedProcedure, "beginTableExecute is null");
-        this.finishCallDistributedProcedure = requireNonNull(finishCallDistributedProcedure, "finishTableExecute is null");
+        this.beginCallDistributedProcedure = requireNonNull(beginCallDistributedProcedure, "beginCallDistributedProcedure is null");
+        this.finishCallDistributedProcedure = requireNonNull(finishCallDistributedProcedure, "finishCallDistributedProcedure is null");
     }
 
     public DistributedProcedureType getType()