Skip to content

Commit 8ae369d

Browse files
committed
refactor(native): Remove folly::StringPiece in Counters.h
1 parent 4a60975 commit 8ae369d

File tree

1 file changed

+65
-65
lines changed
  • presto-native-execution/presto_cpp/main/common

1 file changed

+65
-65
lines changed

presto-native-execution/presto_cpp/main/common/Counters.h

Lines changed: 65 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414
#pragma once
1515

16-
#include <folly/Range.h>
16+
#include <string_view>
1717

1818
// Here we have all the counters presto cpp worker would export.
1919
namespace facebook::presto {
@@ -22,152 +22,152 @@ namespace facebook::presto {
2222
// See velox/common/base/StatsReporter.h for the interface.
2323
void registerPrestoMetrics();
2424

25-
constexpr folly::StringPiece kCounterDriverCPUExecutorQueueSize{
25+
constexpr std::string_view kCounterDriverCPUExecutorQueueSize{
2626
"presto_cpp.driver_cpu_executor_queue_size"};
27-
constexpr folly::StringPiece kCounterDriverCPUExecutorLatencyMs{
27+
constexpr std::string_view kCounterDriverCPUExecutorLatencyMs{
2828
"presto_cpp.driver_cpu_executor_latency_ms"};
29-
constexpr folly::StringPiece kCounterSpillerExecutorQueueSize{
29+
constexpr std::string_view kCounterSpillerExecutorQueueSize{
3030
"presto_cpp.spiller_executor_queue_size"};
31-
constexpr folly::StringPiece kCounterSpillerExecutorLatencyMs{
31+
constexpr std::string_view kCounterSpillerExecutorLatencyMs{
3232
"presto_cpp.spiller_executor_latency_ms"};
33-
constexpr folly::StringPiece kCounterHTTPExecutorLatencyMs{
33+
constexpr std::string_view kCounterHTTPExecutorLatencyMs{
3434
"presto_cpp.http_executor_latency_ms"};
35-
constexpr folly::StringPiece kCounterNumHTTPRequest{
35+
constexpr std::string_view kCounterNumHTTPRequest{
3636
"presto_cpp.num_http_request"};
37-
constexpr folly::StringPiece kCounterNumHTTPRequestError{
37+
constexpr std::string_view kCounterNumHTTPRequestError{
3838
"presto_cpp.num_http_request_error"};
39-
constexpr folly::StringPiece kCounterHTTPRequestLatencyMs{
39+
constexpr std::string_view kCounterHTTPRequestLatencyMs{
4040
"presto_cpp.http_request_latency_ms"};
4141

42-
constexpr folly::StringPiece kCounterHttpClientNumConnectionsCreated{
42+
constexpr std::string_view kCounterHttpClientNumConnectionsCreated{
4343
"presto_cpp.http.client.num_connections_created"};
44-
constexpr folly::StringPiece kCounterHTTPClientTransactionCreateDelay{
44+
constexpr std::string_view kCounterHTTPClientTransactionCreateDelay{
4545
"presto_cpp.http.client.transaction_create_delay_ms"};
4646
/// Peak number of bytes queued in PrestoExchangeSource waiting for consume.
47-
constexpr folly::StringPiece kCounterExchangeSourcePeakQueuedBytes{
47+
constexpr std::string_view kCounterExchangeSourcePeakQueuedBytes{
4848
"presto_cpp.exchange_source_peak_queued_bytes"};
4949

50-
constexpr folly::StringPiece kCounterExchangeRequestDuration{
50+
constexpr std::string_view kCounterExchangeRequestDuration{
5151
"presto_cpp.exchange.request.duration"};
52-
constexpr folly::StringPiece kCounterExchangeRequestNumTries{
52+
constexpr std::string_view kCounterExchangeRequestNumTries{
5353
"presto_cpp.exchange.request.num_tries"};
54-
constexpr folly::StringPiece kCounterExchangeRequestPageSize{
54+
constexpr std::string_view kCounterExchangeRequestPageSize{
5555
"presto_cpp.exchange.request.page_size"};
5656

57-
constexpr folly::StringPiece kCounterExchangeGetDataSizeDuration{
57+
constexpr std::string_view kCounterExchangeGetDataSizeDuration{
5858
"presto_cpp.exchange.get_data_size.duration"};
59-
constexpr folly::StringPiece kCounterExchangeGetDataSizeNumTries{
59+
constexpr std::string_view kCounterExchangeGetDataSizeNumTries{
6060
"presto_cpp.exchange.get_data_size.num_tries"};
6161

62-
constexpr folly::StringPiece kCounterNumQueryContexts{
62+
constexpr std::string_view kCounterNumQueryContexts{
6363
"presto_cpp.num_query_contexts"};
6464
/// Export total bytes used by memory manager (in queries' memory pools).
65-
constexpr folly::StringPiece kCounterMemoryManagerTotalBytes{
65+
constexpr std::string_view kCounterMemoryManagerTotalBytes{
6666
"presto_cpp.memory_manager_total_bytes"};
6767

68-
constexpr folly::StringPiece kCounterNumTasks{"presto_cpp.num_tasks"};
69-
constexpr folly::StringPiece kCounterNumTasksBytesProcessed{
68+
constexpr std::string_view kCounterNumTasks{"presto_cpp.num_tasks"};
69+
constexpr std::string_view kCounterNumTasksBytesProcessed{
7070
"presto_cpp.num_tasks_bytes_processed"};
71-
constexpr folly::StringPiece kCounterNumTasksRunning{
71+
constexpr std::string_view kCounterNumTasksRunning{
7272
"presto_cpp.num_tasks_running"};
73-
constexpr folly::StringPiece kCounterNumTasksFinished{
73+
constexpr std::string_view kCounterNumTasksFinished{
7474
"presto_cpp.num_tasks_finished"};
75-
constexpr folly::StringPiece kCounterNumTasksCancelled{
75+
constexpr std::string_view kCounterNumTasksCancelled{
7676
"presto_cpp.num_tasks_cancelled"};
77-
constexpr folly::StringPiece kCounterNumTasksAborted{
77+
constexpr std::string_view kCounterNumTasksAborted{
7878
"presto_cpp.num_tasks_aborted"};
79-
constexpr folly::StringPiece kCounterNumTasksFailed{
79+
constexpr std::string_view kCounterNumTasksFailed{
8080
"presto_cpp.num_tasks_failed"};
8181
/// Number of the created but not yet started tasks, including queued tasks.
82-
constexpr folly::StringPiece kCounterNumTasksPlanned{
82+
constexpr std::string_view kCounterNumTasksPlanned{
8383
"presto_cpp.num_tasks_planned"};
8484
/// Number of the created tasks in the task queue.
85-
constexpr folly::StringPiece kCounterNumTasksQueued{
85+
constexpr std::string_view kCounterNumTasksQueued{
8686
"presto_cpp.num_tasks_queued"};
8787

88-
constexpr folly::StringPiece kCounterNumZombieVeloxTasks{
88+
constexpr std::string_view kCounterNumZombieVeloxTasks{
8989
"presto_cpp.num_zombie_velox_tasks"};
90-
constexpr folly::StringPiece kCounterNumZombiePrestoTasks{
90+
constexpr std::string_view kCounterNumZombiePrestoTasks{
9191
"presto_cpp.num_zombie_presto_tasks"};
92-
constexpr folly::StringPiece kCounterNumTasksWithStuckOperator{
92+
constexpr std::string_view kCounterNumTasksWithStuckOperator{
9393
"presto_cpp.num_tasks_with_stuck_operator"};
94-
constexpr folly::StringPiece kCounterNumCancelledTasksByStuckDriver{
94+
constexpr std::string_view kCounterNumCancelledTasksByStuckDriver{
9595
"presto_cpp.num_cancelled_tasks_by_stuck_driver"};
96-
constexpr folly::StringPiece kCounterNumTasksDeadlock{
96+
constexpr std::string_view kCounterNumTasksDeadlock{
9797
"presto_cpp.num_tasks_deadlock"};
98-
constexpr folly::StringPiece kCounterNumTaskManagerLockTimeOut{
98+
constexpr std::string_view kCounterNumTaskManagerLockTimeOut{
9999
"presto_cpp.num_tasks_manager_lock_timeout"};
100100

101-
constexpr folly::StringPiece kCounterNumQueuedDrivers{
101+
constexpr std::string_view kCounterNumQueuedDrivers{
102102
"presto_cpp.num_queued_drivers"};
103-
constexpr folly::StringPiece kCounterNumOnThreadDrivers{
103+
constexpr std::string_view kCounterNumOnThreadDrivers{
104104
"presto_cpp.num_on_thread_drivers"};
105-
constexpr folly::StringPiece kCounterNumSuspendedDrivers{
105+
constexpr std::string_view kCounterNumSuspendedDrivers{
106106
"presto_cpp.num_suspended_drivers"};
107-
constexpr folly::StringPiece kCounterNumBlockedWaitForConsumerDrivers{
107+
constexpr std::string_view kCounterNumBlockedWaitForConsumerDrivers{
108108
"presto_cpp.num_blocked_wait_for_consumer_drivers"};
109-
constexpr folly::StringPiece kCounterNumBlockedWaitForSplitDrivers{
109+
constexpr std::string_view kCounterNumBlockedWaitForSplitDrivers{
110110
"presto_cpp.num_blocked_wait_for_split_drivers"};
111-
constexpr folly::StringPiece kCounterNumBlockedWaitForProducerDrivers{
111+
constexpr std::string_view kCounterNumBlockedWaitForProducerDrivers{
112112
"presto_cpp.num_blocked_wait_for_producer_drivers"};
113-
constexpr folly::StringPiece kCounterNumBlockedWaitForJoinBuildDrivers{
113+
constexpr std::string_view kCounterNumBlockedWaitForJoinBuildDrivers{
114114
"presto_cpp.num_blocked_wait_for_join_build_drivers"};
115-
constexpr folly::StringPiece kCounterNumBlockedWaitForJoinProbeDrivers{
115+
constexpr std::string_view kCounterNumBlockedWaitForJoinProbeDrivers{
116116
"presto_cpp.num_blocked_wait_for_join_probe_drivers"};
117-
constexpr folly::StringPiece kCounterNumBlockedWaitForMergeJoinRightSideDrivers{
117+
constexpr std::string_view kCounterNumBlockedWaitForMergeJoinRightSideDrivers{
118118
"presto_cpp.num_blocked_wait_for_merge_join_right_side_drivers"};
119-
constexpr folly::StringPiece kCounterNumBlockedWaitForMemoryDrivers{
119+
constexpr std::string_view kCounterNumBlockedWaitForMemoryDrivers{
120120
"presto_cpp.num_blocked_wait_for_memory_drivers"};
121-
constexpr folly::StringPiece kCounterNumBlockedWaitForConnectorDrivers{
121+
constexpr std::string_view kCounterNumBlockedWaitForConnectorDrivers{
122122
"presto_cpp.num_blocked_wait_for_connector_drivers"};
123-
constexpr folly::StringPiece kCounterNumBlockedYieldDrivers{
123+
constexpr std::string_view kCounterNumBlockedYieldDrivers{
124124
"presto_cpp.num_blocked_yield_drivers"};
125-
constexpr folly::StringPiece kCounterNumStuckDrivers{
125+
constexpr std::string_view kCounterNumStuckDrivers{
126126
"presto_cpp.num_stuck_drivers"};
127127

128128
/// Export 100 if worker is overloaded in terms of memory, 0 otherwise.
129-
constexpr folly::StringPiece kCounterOverloadedMem{"presto_cpp.overloaded_mem"};
129+
constexpr std::string_view kCounterOverloadedMem{"presto_cpp.overloaded_mem"};
130130
/// Export 100 if worker is overloaded in terms of CPU, 0 otherwise.
131-
constexpr folly::StringPiece kCounterOverloadedCpu{"presto_cpp.overloaded_cpu"};
131+
constexpr std::string_view kCounterOverloadedCpu{"presto_cpp.overloaded_cpu"};
132132
/// Export 100 if worker is overloaded in terms of memory or CPU, 0 otherwise.
133-
constexpr folly::StringPiece kCounterOverloaded{"presto_cpp.overloaded"};
133+
constexpr std::string_view kCounterOverloaded{"presto_cpp.overloaded"};
134134
/// Worker exports the average time tasks spend in the queue (considered
135135
/// planned) in milliseconds.
136-
constexpr folly::StringPiece kCounterTaskPlannedTimeMs{
136+
constexpr std::string_view kCounterTaskPlannedTimeMs{
137137
"presto_cpp.task_planned_time_ms"};
138138

139139
/// Number of total OutputBuffer managed by all
140140
/// OutputBufferManager
141-
constexpr folly::StringPiece kCounterTotalPartitionedOutputBuffer{
141+
constexpr std::string_view kCounterTotalPartitionedOutputBuffer{
142142
"presto_cpp.num_partitioned_output_buffer"};
143143
/// Latency in millisecond of the get data call of a
144144
/// OutputBufferManager.
145-
constexpr folly::StringPiece kCounterPartitionedOutputBufferGetDataLatencyMs{
145+
constexpr std::string_view kCounterPartitionedOutputBufferGetDataLatencyMs{
146146
"presto_cpp.partitioned_output_buffer_get_data_latency_ms"};
147147

148148
/// ================== OS Counters =================
149149

150150
/// User CPU time of the presto_server process in microsecond since the process
151151
/// start.
152-
constexpr folly::StringPiece kCounterOsUserCpuTimeMicros{
152+
constexpr std::string_view kCounterOsUserCpuTimeMicros{
153153
"presto_cpp.os_user_cpu_time_micros"};
154154
/// System CPU time of the presto_server process in microsecond since the
155155
/// process start.
156-
constexpr folly::StringPiece kCounterOsSystemCpuTimeMicros{
156+
constexpr std::string_view kCounterOsSystemCpuTimeMicros{
157157
"presto_cpp.os_system_cpu_time_micros"};
158158
/// Total number of soft page faults of the presto_server process in microsecond
159159
/// since the process start.
160-
constexpr folly::StringPiece kCounterOsNumSoftPageFaults{
160+
constexpr std::string_view kCounterOsNumSoftPageFaults{
161161
"presto_cpp.os_num_soft_page_faults"};
162162
/// Total number of hard page faults of the presto_server process in microsecond
163163
/// since the process start.
164-
constexpr folly::StringPiece kCounterOsNumHardPageFaults{
164+
constexpr std::string_view kCounterOsNumHardPageFaults{
165165
"presto_cpp.os_num_hard_page_faults"};
166166
/// Total number of voluntary context switches in the presto_server process.
167-
constexpr folly::StringPiece kCounterOsNumVoluntaryContextSwitches{
167+
constexpr std::string_view kCounterOsNumVoluntaryContextSwitches{
168168
"presto_cpp.os_num_voluntary_context_switches"};
169169
/// Total number of involuntary context switches in the presto_server process.
170-
constexpr folly::StringPiece kCounterOsNumForcedContextSwitches{
170+
constexpr std::string_view kCounterOsNumForcedContextSwitches{
171171
"presto_cpp.os_num_forced_context_switches"};
172172

173173
/// ================== HiveConnector Counters ==================
@@ -204,30 +204,30 @@ constexpr std::string_view kCounterThreadPoolMaxIdleTimeNsFormat{
204204
"presto_cpp.{}.max_idle_time_ns"};
205205

206206
/// ================== EVB Counters ====================
207-
constexpr folly::StringPiece kCounterExchangeIoEvbViolation{
207+
constexpr std::string_view kCounterExchangeIoEvbViolation{
208208
"presto_cpp.exchange_io_evb_violation_count"};
209-
constexpr folly::StringPiece kCounterHttpServerIoEvbViolation{
209+
constexpr std::string_view kCounterHttpServerIoEvbViolation{
210210
"presto_cpp.http_server_io_evb_violation_count"};
211211

212212
/// ================== Memory Pushback Counters =================
213213

214214
/// Number of times memory pushback mechanism is triggered.
215-
constexpr folly::StringPiece kCounterMemoryPushbackCount{
215+
constexpr std::string_view kCounterMemoryPushbackCount{
216216
"presto_cpp.memory_pushback_count"};
217217
/// Latency distribution of each memory pushback run in range of [0, 100s] and
218218
/// reports P50, P90, P99, and P100.
219-
constexpr folly::StringPiece kCounterMemoryPushbackLatencyMs{
219+
constexpr std::string_view kCounterMemoryPushbackLatencyMs{
220220
"presto_cpp.memory_pushback_latency_ms"};
221221
/// Distribution of actual reduction in memory usage achieved by each memory
222222
/// pushback attempt. This is to gauge its effectiveness. In range of [0, 15GB]
223223
/// with 150 buckets and reports P50, P90, P99, and P100.
224-
constexpr folly::StringPiece kCounterMemoryPushbackReductionBytes{
224+
constexpr std::string_view kCounterMemoryPushbackReductionBytes{
225225
"presto_cpp.memory_pushback_reduction_bytes"};
226226
/// Distribution of expected reduction in memory usage achieved by each memory
227227
/// pushback attempt. This is to gauge its effectiveness. In range of [0, 15GB]
228228
/// with 150 buckets and reports P50, P90, P99, and P100. The expected reduction
229229
/// can be different as other threads might have allocated memory in the
230230
/// meantime.
231-
constexpr folly::StringPiece kCounterMemoryPushbackExpectedReductionBytes{
231+
constexpr std::string_view kCounterMemoryPushbackExpectedReductionBytes{
232232
"presto_cpp.memory_pushback_expected_reduction_bytes"};
233233
} // namespace facebook::presto

0 commit comments

Comments
 (0)