-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit 8c65c9a
authored
refactor(ui): Convert class to components to function components, pt 2 (#25904)
## Description
Third batch of the component conversion started in
#25666 (please see PR for
background details). This finishes converting all the components in the
`components/` folder from class components to function components, and
with the other two PRs in this series, finishes converting all the class
components in the application.
## Motivation and Context
Resolves item 12 in #21062; function components are the new de-facto
standard in react, and benefit from ongoing optimizations in current and
future react versions.
## Impact
UI
## Test Plan
Tested the UI interface extensively, checking all refactored components
and their interactions.
Components/interactions tested:
- QueryDetail - including sparkline charts
- QueryHeader
- QueryList
- OperatorSummary
- OperatorStatistics
- OperatorDetail
- StageOperatorGraph
- StageDetail
## Contributor checklist
- [x] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [x] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [x] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [x] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [x] Adequate tests were added if applicable.
- [x] CI passed.
## Release Notes
```
== NO RELEASE NOTE ==
```1 parent 963c79a commit 8c65c9aCopy full SHA for 8c65c9a
File tree
Expand file treeCollapse file tree
5 files changed
+1780
-1775
lines changedOpen diff view settings
Filter options
- presto-ui/src/components
Expand file treeCollapse file tree
5 files changed
+1780
-1775
lines changedOpen diff view settings
0 commit comments