Skip to content

Commit 947df95

Browse files
committed
Fix test failure caused by concurrent operations on the same table
1 parent 42db0da commit 947df95

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedSmokeTestBase.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
import static com.facebook.presto.iceberg.procedure.RegisterTableProcedure.getFileSystem;
7474
import static com.facebook.presto.iceberg.procedure.RegisterTableProcedure.resolveLatestMetadataLocation;
7575
import static com.facebook.presto.testing.MaterializedResult.resultBuilder;
76+
import static com.facebook.presto.tests.sql.TestTable.randomTableSuffix;
7677
import static com.google.common.base.Preconditions.checkArgument;
7778
import static com.google.common.collect.Iterables.getOnlyElement;
7879
import static java.lang.String.format;
@@ -1983,7 +1984,7 @@ public void testMetadataDeleteOnTableAfterWholeRewriteDataFiles(String version,
19831984
{
19841985
String errorMessage = "This connector only supports delete where one or more partitions are deleted entirely.*";
19851986
String schemaName = getSession().getSchema().get();
1986-
String tableName = "test_rewrite_data_files_table";
1987+
String tableName = "test_rewrite_data_files_table_" + randomTableSuffix();
19871988
try {
19881989
// Create a table with partition column `a`, and insert some data under this partition spec
19891990
assertUpdate("CREATE TABLE " + tableName + " (a INTEGER, b VARCHAR) WITH (format_version = '" + version + "', delete_mode = '" + mode + "')");
@@ -2013,7 +2014,7 @@ public void testMetadataDeleteOnTableAfterPartialRewriteDataFiles(String version
20132014
{
20142015
String errorMessage = "This connector only supports delete where one or more partitions are deleted entirely.*";
20152016
String schemaName = getSession().getSchema().get();
2016-
String tableName = "test_rewrite_data_files_table";
2017+
String tableName = "test_rewrite_data_files_table_" + randomTableSuffix();
20172018
try {
20182019
// Create a table with partition column `a`, and insert some data under this partition spec
20192020
assertUpdate("CREATE TABLE " + tableName + " (a INTEGER, b VARCHAR) WITH (format_version = '" + version + "', delete_mode = '" + mode + "', partitioning = ARRAY['a'])");

presto-iceberg/src/test/java/com/facebook/presto/iceberg/IcebergDistributedTestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2032,7 +2032,7 @@ public void testDecimal(boolean decimalVectorReaderEnabled)
20322032

20332033
public void testMetadataDeleteOnV2MorTableWithRewriteDataFiles()
20342034
{
2035-
String tableName = "test_rewrite_data_files_table";
2035+
String tableName = "test_rewrite_data_files_table_" + randomTableSuffix();
20362036
try {
20372037
// Create a table with partition column `a`, and insert some data under this partition spec
20382038
assertUpdate("CREATE TABLE " + tableName + " (a INTEGER, b VARCHAR) WITH (format_version = '2', delete_mode = 'merge-on-read')");

0 commit comments

Comments
 (0)