Commit c57d320
authored
misc: Remove unused includes (#27026)
Summary:
Clean up unused includes in presto_cpp/main to improve compilation times
and reduce unnecessary header dependencies:
1. Announcer.cpp:
- Removed `folly/futures/Retrying.h` - no retrying symbols used
- Removed `velox/common/memory/Memory.h` - no memory pool symbols used
2. PeriodicHeartbeatManager.cpp:
- Removed `velox/common/memory/Memory.h` - no memory symbols used
3. PrestoExchangeSource.cpp:
- Replaced `QueryContextManager.h` with the more specific
`presto_protocol/core/presto_protocol_core.h` which directly provides
the protocol namespace symbols (DataSize, Duration, PRESTO_*_HEADER
constants) that are actually used. This avoids pulling in heavy
transitive dependencies from QueryContextManager.h like
folly/Synchronized, folly/executors/*, and velox/core/QueryCtx.h.
## Summary by Sourcery
Clean up unused and overly broad header dependencies in presto_cpp main
sources to reduce compile-time and transitive includes.
Enhancements:
- Remove unused header includes from Announcer and
PeriodicHeartbeatManager to simplify dependencies.
- Narrow PrestoExchangeSource's dependency from QueryContextManager to
the specific presto_protocol_core header that provides the required
protocol types and constants.
```
== NO RELEASE NOTE ==
```1 parent c53e51d commit c57d320
File tree
3 files changed
+1
-4
lines changed- presto-native-execution/presto_cpp/main
3 files changed
+1
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | 19 | | |
22 | 20 | | |
23 | 21 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
0 commit comments