Skip to content

spark2 maven profile is always active, maven enforcer not enabled #26465

@aaneja

Description

@aaneja

This change added the spark2 root pom profile -

<activation>
    <activeByDefault>true</activeByDefault>
    <property>
        <name>!spark-version</name>
    </property>
</activation>

Since most users (and I think the CI) do not build with -Dspark-version set to a valid value, this spark2 profile is always active. I confirmed this via ./mvnw help:active-profiles

Issue

The spark2 profile skips the enforcer check by default -

<configuration>
     <skip>true</skip>

Due to this maven enforcer has not been executing on the CI jobs

For example, the #26378 PR updates logback-core to a version not compatible with presto-main-base but the CI did not flag this

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    🆕 Unprioritized

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions