Skip to content

Conversation

@xin-zhang2
Copy link
Contributor

Description

Fixes a potential NPE issue in HttpNativeExecutionTaskResultFetcher.
See #22338

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@xin-zhang2 xin-zhang2 requested review from a team and shrinidhijoshi as code owners November 6, 2025 12:02
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 6, 2025
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and libianoss and removed request for a team November 6, 2025 12:03
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

HttpNativeExecutionTaskResultFetcher’s onSuccess handler now safely cancels the scheduledFuture by guarding against null, preventing potential NPE.

Class diagram for updated HttpNativeExecutionTaskResultFetcher.onSuccess() null check

classDiagram
class HttpNativeExecutionTaskResultFetcher {
    -ScheduledFuture scheduledFuture
    +void onSuccess(PageBufferClient.PagesResponse pagesResponse)
}
class PageBufferClient {
    +void abortResultsAsync()
}
class PagesResponse {
    +boolean isClientComplete()
}
HttpNativeExecutionTaskResultFetcher --> PageBufferClient
PageBufferClient --> PagesResponse
Loading

File-Level Changes

Change Details Files
Guard against null scheduledFuture before canceling to prevent NPE
  • Added check for scheduledFuture != null before calling cancel(false)
presto-spark-base/src/main/java/com/facebook/presto/spark/execution/nativeprocess/HttpNativeExecutionTaskResultFetcher.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@xin-zhang2 xin-zhang2 changed the title fix(native): Fix NPE in HttpNativeExecutionTaskResultFetcher fix(native): Fix an NPE issue in HttpNativeExecutionTaskResultFetcher Nov 6, 2025
Copy link
Member

@hantangwangd hantangwangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xin-zhang2 thanks for this fix, basically looks good to me.

This seems to be a race condition: an async task is scheduled immediately to potentially cancel the result future of this scheduling operation (which may not be assigned yet). Not very sure, but do you think it's reasonable to change the initialDelay to a value bigger than 0 in the following code, since the scheduled task doGetResults may try to cancel ScheduledFuture<?> future before it's assigned:

ScheduledFuture<?> future = scheduler.scheduleAtFixedRate(this::doGetResults,
                0,
                (long) FETCH_INTERVAL.getValue(),
                FETCH_INTERVAL.getUnit());

wdyt: @shrinidhijoshi @xin-zhang2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants