Skip to content

Commit 78ce425

Browse files
authored
Merge pull request #6 from elharo/typo
2 parents b92dd90 + 01890e3 commit 78ce425

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ To create one:
2020

2121
1. Fork the https://github.com/prestodb/rfcs repository
2222
2. Copy the template file `RFC-0000-template.md` to `RFC-00xx-your-feature.md` and fill it out with your proposal.
23-
The template is a guideline, feel free to add sections as appropriate
24-
3. You may also have the template simply link to another editor, like a Google Docs file, but please ensure that the
25-
document is publicly visible. This can make the template easier to add edit, but commenting doesn’t scale very well, so
23+
The template is a guideline. Feel free to add sections as appropriate.
24+
3. The RFC may simply link to another editor, like a Google Docs file, but please ensure that the
25+
document is publicly visible. This can make the RFC easier to edit, but commenting doesn’t scale very well, so
2626
please use this option with caution.
2727

2828
## Step 2: Get Feedback on the RFC
@@ -34,14 +34,14 @@ To create one:
3434
4. A committer will review your proposal.
3535
5. Build consensus. Those committers will review your PR and offer feedback. Revise your proposal as needed until
3636
everyone agrees on a path forward. Additional forums you can share the proposal on include the
37-
[the mailing list](https://lists.prestodb.io/g/presto-dev), and the
37+
[the mailing list](https://lists.prestodb.io/g/presto-dev) and the
3838
[Slack channel in #dev](https://communityinviter.com/apps/prestodb/prestodb). Tagging interested stakeholders
3939
(identifiable via [CODEOWNERS](https://github.com/prestodb/presto/blob/master/CODEOWNERS)) can help with consensus building.
4040

4141
_(Note: A proposal may get rejected if it comes with unresolvable drawbacks or if it’s against the long term plans of the Presto committers)_
4242

4343
## Step 3: Implement your Feature
44-
1. If your RFC PR is accepted then the PR will be merged.
44+
1. If your RFC PR is accepted, then the PR will be merged.
4545
2. As soon as possible, create an issue in Github in the relevant repository (most likely
4646
[prestodb/presto](https://github.com/prestodb/presto)) summarizing the RFC and linking to it.
4747
3. When you submit PRs to implement your proposal, remember to link to your issue that has a link to the RFC

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ an opportunity to suggest refinements before you start code. For example, they
1313
your work would otherwise collide with, or they may suggest implementation changes that make your feature more broadly
1414
usable.
1515

16-
Smaller changes, including bug fixes and documentation improvements can be implemented and reviewed via the normal
16+
Smaller changes, including bug fixes and documentation improvements, can be implemented and reviewed via the normal
1717
GitHub pull request workflow on the main Presto repo.
1818

1919
RFCs are more suitable for design proposals that are too large to discuss on a feature-request issue, like adding new

0 commit comments

Comments
 (0)