Skip to content

Commit 7e34f9e

Browse files
authored
we can import fs/promises since it's only used in a node environment. (#1062)
1 parent 7641856 commit 7e34f9e

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

test.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default {
1111
optimization: { minimize: false },
1212
target: ['browserslist'],
1313

14-
externals: { 'fs/promises': 'fs/promises' },
14+
externals: { 'fs/promises': 'import fs/promises' },
1515

1616
experiments: {
1717
asyncWebAssembly: true,

tests/config/get-plugins.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ if (process.env.TEST_STANDALONE) {
1515
? self
1616
: this || {};
1717
root.prettier = await getPrettier();
18-
root["fs/promises"] = await import("fs/promises");
1918
}
2019

2120
function getPluginsInternal() {

webpack.config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@ export default (webpackEnv) => {
2020
entry: './src/index.js',
2121

2222
// Avoid bundling Prettier
23-
externalsType: 'global',
2423
externals: {
25-
prettier: 'prettier',
26-
'fs/promises': 'fs/promises'
24+
prettier: 'global prettier',
25+
'fs/promises': 'import fs/promises'
2726
},
2827

2928
plugins: [

0 commit comments

Comments
 (0)