test: refactor tests (#275)

Author: fisker

tests/__snapshots__/transform.test.ts.snap

@@ -1,38 +1,60 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[` (EmptyExpr -> NGEmptyExpression) ast 1`] = `
-NGEmptyExpression {
+exports[`(BindingPipe -> NGPipeExpression) parseBinding(" a | b ") 1`] = `
+NGPipeExpression {
+  "left": "Identifier",
+  "right": "Identifier",
+  "arguments": [],
   "comments": []
 }
-> 1 |
-    | ^
+> 1 |  a | b 
+    |  ^^^^^
+--------------------------------------------------------------------------------
+Identifier {
+  "name": "a"
+}
+> 1 |  a | b 
+    |  ^
+--------------------------------------------------------------------------------
+Identifier {
+  "name": "b"
+}
+> 1 |  a | b 
+    |      ^
 `;
 
-exports[` a ; b  (Chain -> NGChainedExpression) ast 1`] = `
-NGChainedExpression {
-  "expressions": [
-    "Identifier",
+exports[`(BindingPipe -> NGPipeExpression) parseBinding(" a | b : c ") 1`] = `
+NGPipeExpression {
+  "left": "Identifier",
+  "right": "Identifier",
+  "arguments": [
     "Identifier"
   ],
   "comments": []
 }
-> 1 |  a ; b 
-    |  ^^^^^
+> 1 |  a | b : c 
+    |  ^^^^^^^^^
 --------------------------------------------------------------------------------
 Identifier {
   "name": "a"
 }
-> 1 |  a ; b 
+> 1 |  a | b : c 
     |  ^
 --------------------------------------------------------------------------------
 Identifier {
   "name": "b"
 }
-> 1 |  a ; b 
+> 1 |  a | b : c 
     |      ^
+--------------------------------------------------------------------------------
+Identifier {
+  "name": "c"
+}
+> 1 |  a | b : c 
+    |          ^
 `;
 
-exports[` a | b  (BindingPipe -> NGPipeExpression) ast 1`] = `
+exports[`(BindingPipe -> NGPipeExpression) parseInterpolationExpression(" a | b ") 1`] = `
 NGPipeExpression {
   "left": "Identifier",
   "right": "Identifier",
@@ -55,7 +77,7 @@ Identifier {
     |      ^
 `;
 
-exports[` a | b : c  (BindingPipe -> NGPipeExpression) ast 1`] = `
+exports[`(BindingPipe -> NGPipeExpression) parseInterpolationExpression(" a | b : c ") 1`] = `
 NGPipeExpression {
   "left": "Identifier",
   "right": "Identifier",
@@ -85,3 +107,59 @@ Identifier {
 > 1 |  a | b : c 
     |          ^
 `;
+
+exports[`(Chain -> NGChainedExpression) parseAction(" a ; b ") 1`] = `
+NGChainedExpression {
+  "expressions": [
+    "Identifier",
+    "Identifier"
+  ],
+  "comments": []
+}
+> 1 |  a ; b 
+    |  ^^^^^
+--------------------------------------------------------------------------------
+Identifier {
+  "name": "a"
+}
+> 1 |  a ; b 
+    |  ^
+--------------------------------------------------------------------------------
+Identifier {
+  "name": "b"
+}
+> 1 |  a ; b 
+    |      ^
+`;
+
+exports[`(EmptyExpr -> NGEmptyExpression) parseAction("") 1`] = `
+NGEmptyExpression {
+  "comments": []
+}
+> 1 |
+    | ^
+`;
+
+exports[`(EmptyExpr -> NGEmptyExpression) parseBinding("") 1`] = `
+NGEmptyExpression {
+  "comments": []
+}
+> 1 |
+    | ^
+`;
+
+exports[`(EmptyExpr -> NGEmptyExpression) parseInterpolationExpression("") 1`] = `
+NGEmptyExpression {
+  "comments": []
+}
+> 1 |
+    | ^
+`;
+
+exports[`(EmptyExpr -> NGEmptyExpression) parseSimpleBinding("") 1`] = `
+NGEmptyExpression {
+  "comments": []
+}
+> 1 |
+    | ^
+`;

tests/helpers.ts

@@ -1,4 +1,5 @@
 import { codeFrameColumns } from '@babel/code-frame';
+import type * as b from '@babel/types';
 import * as babelParser from '@babel/parser';
 import { LinesAndColumns } from 'lines-and-columns';
 import { wrap } from 'jest-snapshot-serializer-raw';
@@ -10,20 +11,31 @@ const babelParserOptions: babelParser.ParserOptions = {
   ranges: true,
 };
 
-export function parseBabelExpression(input: string) {
-  return babelParser.parseExpression(input, babelParserOptions);
-}
-
-export function parseBabel(input: string) {
-  const ast = babelParser.parse(input, babelParserOptions);
+function fixBabelCommentsRange(
+  ast: (
+    | ReturnType<typeof babelParser.parse>
+    | ReturnType<typeof babelParser.parseExpression>
+  ) & { comments?: b.Comment[] | null },
+) {
   // https://github.com/babel/babel/issues/15115
   for (const comment of ast.comments!) {
     // @ts-expect-error -- missing types
     comment.range ??= [comment.start, comment.end];
   }
+
   return ast;
 }
 
+export function parseBabelExpression(input: string) {
+  return fixBabelCommentsRange(
+    babelParser.parseExpression(input, babelParserOptions),
+  );
+}
+
+export function parseBabel(input: string) {
+  return fixBabelCommentsRange(babelParser.parse(input, babelParserOptions));
+}
+
 export function massageAst(ast: any): any {
   if (!ast || typeof ast !== 'object') {
     return ast;