Remove paren{Start,End}

Author: fisker

src/transform-node.ts

@@ -32,33 +32,6 @@ function isImplicitThis(node: angular.AST, text: string): boolean {
   return start >= end || /^\s+$/.test(text.slice(start, end));
 }
 
-function getParenthesizedInformation(ancestors: angular.AST[]) {
-  const parenthesizedExpression =
-    getOutermostParenthesizedExpression(ancestors);
-
-  if (!parenthesizedExpression) {
-    return;
-  }
-
-  return {
-    parenthesized: true,
-    parenStart: parenthesizedExpression.sourceSpan.start,
-    parenEnd: parenthesizedExpression.sourceSpan.end,
-  };
-}
-
-function getOutermostParenthesizedExpression(ancestors: angular.AST[]) {
-  for (const [index, node] of ancestors.entries()) {
-    if (!(node instanceof angular.ParenthesizedExpression)) {
-      return;
-    }
-
-    if (!(ancestors[index + 1] instanceof angular.ParenthesizedExpression)) {
-      return node;
-    }
-  }
-}
-
 type NodeTransformOptions = {
   ancestors: angular.AST[];
 };
@@ -85,11 +58,10 @@ class Transformer extends Source {
   ) {
     const node = this.createNode(properties);
 
-    const parenthesizedInformation = getParenthesizedInformation(ancestors);
-    if (parenthesizedInformation) {
+    if (ancestors[0] instanceof angular.ParenthesizedExpression) {
       node.extra = {
         ...node.extra,
-        ...parenthesizedInformation,
+        parenthesized: true,
       };
     }
 

tests/__snapshots__/transform.test.ts.snap

@@ -6,9 +6,7 @@ NGPipeExpression {
   "right": "Identifier",
   "arguments": [],
   "extra": {
-    "parenthesized": true,
-    "parenStart": 1,
-    "parenEnd": 23
+    "parenthesized": true
   },
   "comments": []
 }
@@ -18,9 +16,7 @@ NGPipeExpression {
 Identifier {
   "name": "a",
   "extra": {
-    "parenthesized": true,
-    "parenStart": 5,
-    "parenEnd": 14
+    "parenthesized": true
   }
 }
 > 1 |  ( ( ( ( a ) ) |  b  )) 
@@ -29,9 +25,7 @@ Identifier {
 Identifier {
   "name": "b",
   "extra": {
-    "parenthesized": true,
-    "parenStart": 1,
-    "parenEnd": 23
+    "parenthesized": true
   }
 }
 > 1 |  ( ( ( ( a ) ) |  b  )) 
@@ -75,9 +69,7 @@ NGPipeExpression {
   "right": "Identifier",
   "arguments": [],
   "extra": {
-    "parenthesized": true,
-    "parenStart": 1,
-    "parenEnd": 23
+    "parenthesized": true
   },
   "comments": []
 }
@@ -87,9 +79,7 @@ NGPipeExpression {
 Identifier {
   "name": "a",
   "extra": {
-    "parenthesized": true,
-    "parenStart": 5,
-    "parenEnd": 14
+    "parenthesized": true
   }
 }
 > 1 |  ( ( ( ( a ) ) |  b  )) 
@@ -98,9 +88,7 @@ Identifier {
 Identifier {
   "name": "b",
   "extra": {
-    "parenthesized": true,
-    "parenStart": 1,
-    "parenEnd": 23
+    "parenthesized": true
   }
 }
 > 1 |  ( ( ( ( a ) ) |  b  )) 

tests/helpers.ts

@@ -46,6 +46,10 @@ export function massageAst(ast: any, parser: 'babel' | 'angular'): any {
     return ast.map((node) => massageAst(node, parser));
   }
 
+  if (parser === 'babel' && typeof ast.extra?.parenStart === 'number') {
+    delete ast.extra.parenStart;
+  }
+
   // Not exists in types, but exists in node.
   if (ast.type === 'ObjectProperty') {
     if (ast.method !== undefined && ast.method !== false) {
@@ -54,6 +58,7 @@ export function massageAst(ast: any, parser: 'babel' | 'angular'): any {
       );
     }
     delete ast.method;
+
     if (
       ast.shorthand &&
       ast.extra &&