Fix transform of ThisReceiver

Author: fisker

src/transform-node.ts

@@ -171,7 +171,7 @@ class Transformer extends Source {
       return createNode<NGEmptyExpression>({ type: 'NGEmptyExpression' });
     }
 
-    if (node instanceof angular.ImplicitReceiver) {
+    if (node instanceof angular.ThisReceiver) {
       return createNode<babel.ThisExpression>({ type: 'ThisExpression' });
     }
 

tests/helpers.ts

@@ -110,42 +110,10 @@ function visitAst(ast: any, fn: (node: any) => void) {
   Object.keys(ast).forEach((key) => visitAst(ast[key], fn));
 }
 
-const KNOWN_AST_TYPES = [
-  'ASTWithSource',
-  'Unary',
-  'Binary',
-  'BindingPipe',
-  'Call',
-  'Chain',
-  'Conditional',
-  'EmptyExpr',
-  'ImplicitReceiver',
-  'KeyedRead',
-  'SafeKeyedRead',
-  'TypeofExpression',
-  'LiteralArray',
-  'LiteralMap',
-  'LiteralPrimitive',
-  'NonNullAssert',
-  'PrefixNot',
-  'PropertyRead',
-  'SafeCall',
-  'SafePropertyRead',
-  'ThisReceiver',
-  'Interpolation',
-  'VoidExpression',
-  'TemplateLiteral',
-  'TaggedTemplateLiteral',
-  'ParenthesizedExpression',
-] as const;
-
 export function getAngularNodeType(node: angular.AST) {
-  if (node instanceof angular.ParenthesizedExpression) {
-    return getAngularNodeType(node.expression);
+  while (node instanceof angular.ParenthesizedExpression) {
+    node = node.expression;
   }
 
-  return (
-    KNOWN_AST_TYPES.find((type) => node instanceof angular[type]) ??
-    node.constructor.name
-  );
+  return node.constructor.name;
 }

tests/transform.test.ts

@@ -189,7 +189,7 @@ const testCases: TestCase[] = [
     text: ' a ?. b () ?. [ c ] ',
   },
   {
-    expectedAngularType: 'ImplicitReceiver',
+    expectedAngularType: 'ThisReceiver',
     expectedEstreeType: 'ThisExpression',
     text: ' this ',
   },