refactor(bazel): remove primary_bundle_name as attr for ng_package (angular#60306)

Remove primary_bundle_name as an attr for ng_package as it is unused.

PR Close angular#60306

Author: josephperrott

packages/bazel/src/ng_package/ng_package.bzl

@@ -265,11 +265,9 @@ def _ng_package_impl(ctx):
     npm_package_directory = ctx.actions.declare_directory("%s.ng_pkg" % ctx.label.name)
     owning_package = ctx.label.package
 
-    # The name of the primary entry-point FESM bundles. If not explicitly provided through
-    # the entry-point name attribute, we compute the name from the owning package
-    # e.g. if defined in `packages/core:npm_package`, the name is resolved to be `core`.
-    primary_bundle_name = \
-        ctx.attr.primary_bundle_name if ctx.attr.primary_bundle_name else owning_package.split("/")[-1]
+    # The name of the primary entry-point FESM bundles, computed name from the owning package
+    # e.g. For `packages/core:npm_package`, the name is resolved to be `core`.
+    primary_bundle_name = owning_package.split("/")[-1]
 
     # Static files are files which are simply copied over into the tree artifact. These files
     # are not picked up by the entry-point bundling etc. Can also be generated by e.g. a genrule.
@@ -564,9 +562,6 @@ _NG_PACKAGE_ATTRS = dict(PKG_NPM_ATTRS, **{
         cfg = partial_compilation_transition,
     ),
     "readme_md": attr.label(allow_single_file = [".md"]),
-    "primary_bundle_name": attr.string(
-        doc = "Name to use when generating bundle files for the primary entry-point.",
-    ),
     "ng_packager": attr.label(
         default = Label(_DEFAULT_NG_PACKAGER),
         executable = True,

packages/bazel/test/ng_package/example/BUILD.bazel

@@ -28,7 +28,6 @@ ng_package(
     nested_packages = [
         ":arbitrary_npm_package",
     ],
-    primary_bundle_name = "waffels",
     deps = [
         ":example",
         "//packages/bazel/test/ng_package/example/a11y",

packages/bazel/test/ng_package/example_package.golden

@@ -10,14 +10,14 @@ extra-styles.css
 fesm2022
   fesm2022/a11y.mjs
   fesm2022/a11y.mjs.map
+  fesm2022/example.mjs
+  fesm2022/example.mjs.map
   fesm2022/imports.mjs
   fesm2022/imports.mjs.map
   fesm2022/index-1e1ea2d8.mjs
   fesm2022/index-1e1ea2d8.mjs.map
   fesm2022/secondary.mjs
   fesm2022/secondary.mjs.map
-  fesm2022/waffels.mjs
-  fesm2022/waffels.mjs.map
 imports
   imports/index.d.ts
 index.d.ts
@@ -143,6 +143,31 @@ export { A11yModule };
 //# sourceMappingURL=a11y.mjs.map
 
 
+--- fesm2022/example.mjs ---
+
+/**
+ * @license Angular v0.0.0
+ * (c) 2010-2025 Google LLC. https://angular.io/
+ * License: MIT
+ */
+
+import * as i0 from '@angular/core';
+import { NgModule } from '@angular/core';
+
+class MyModule {
+    static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule, deps: [], target: i0.ɵɵFactoryTarget.NgModule });
+    static ɵmod = i0.ɵɵngDeclareNgModule({ minVersion: "14.0.0", version: "0.0.0", ngImport: i0, type: MyModule });
+    static ɵinj = i0.ɵɵngDeclareInjector({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule });
+}
+i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule, decorators: [{
+            type: NgModule,
+            args: [{}]
+        }] });
+
+export { MyModule };
+//# sourceMappingURL=example.mjs.map
+
+
 --- fesm2022/imports.mjs ---
 
 /**
@@ -222,31 +247,6 @@ export { SecondaryModule, a };
 //# sourceMappingURL=secondary.mjs.map
 
 
---- fesm2022/waffels.mjs ---
-
-/**
- * @license Angular v0.0.0
- * (c) 2010-2025 Google LLC. https://angular.io/
- * License: MIT
- */
-
-import * as i0 from '@angular/core';
-import { NgModule } from '@angular/core';
-
-class MyModule {
-    static ɵfac = i0.ɵɵngDeclareFactory({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule, deps: [], target: i0.ɵɵFactoryTarget.NgModule });
-    static ɵmod = i0.ɵɵngDeclareNgModule({ minVersion: "14.0.0", version: "0.0.0", ngImport: i0, type: MyModule });
-    static ɵinj = i0.ɵɵngDeclareInjector({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule });
-}
-i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "0.0.0", ngImport: i0, type: MyModule, decorators: [{
-            type: NgModule,
-            args: [{}]
-        }] });
-
-export { MyModule };
-//# sourceMappingURL=waffels.mjs.map
-
-
 --- imports/index.d.ts ---
 
 /**
@@ -308,7 +308,7 @@ export { }
     ".": {
       "sass": "./_index.scss",
       "types": "./index.d.ts",
-      "default": "./fesm2022/waffels.mjs"
+      "default": "./fesm2022/example.mjs"
     },
     "./package.json": {
       "default": "./package.json"
@@ -326,7 +326,7 @@ export { }
       "default": "./fesm2022/secondary.mjs"
     }
   },
-  "module": "./fesm2022/waffels.mjs",
+  "module": "./fesm2022/example.mjs",
   "typings": "./index.d.ts",
   "type": "module"
 }