Skip to content

Commit 22ad71d

Browse files
alan-agius4thePunderWoman
authored andcommitted
refactor: improve release process instructions and vsce login handling
This commit introduces several improvements to the release process: - Adds a clear warning and instructions to test the extension before merging the release PR - Removes the explicit `vsce login` command.
1 parent d2fe867 commit 22ad71d

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

vscode-ng-language-service/tools/release.mts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,18 @@ async function waitForPRToBeMergedAndTag(
281281
newVersion: string,
282282
branchToReleaseFrom: string,
283283
): Promise<void> {
284-
console.log('');
285-
console.log('Waiting for release PR to be merged...');
284+
console.log(
285+
chalk.yellow(`
286+
=======================
287+
⚠️ ACTION REQUIRED ⚠️
288+
=======================
289+
290+
Before merging the PR, you should install the extension at: ${extensionPath} and test it.
291+
292+
Once you press Enter, the process will tag and publish automatically.
293+
`),
294+
);
295+
286296
await input({
287297
message: 'Press Enter once the release PR has been merged.',
288298
});
@@ -341,8 +351,7 @@ async function publishExtension(): Promise<void> {
341351
console.log(`VSIX path: ${extensionPath}`);
342352
console.log(`Please get a PAT token from: http://go/secret-tunnel/1575675884599726`);
343353

344-
console.log('');
345-
await execAndStream('pnpm', ['--filter="ng-template"', 'vsce', 'login', 'Angular']);
354+
// NOTE: `vsce publish` will prompt for login if the user is not already authenticated.
346355

347356
console.log('');
348357
console.log(chalk.blue('Publishing extension'));

0 commit comments

Comments
 (0)