refactor(common): drop error messages in production (angular#60242)

Drops more error messages in production.

PR Close angular#60242

Author: arturovt

goldens/public-api/common/errors.api.md

@@ -15,6 +15,8 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     INVALID_PIPE_ARGUMENT = 2100,
     // (undocumented)
+    INVALID_TO_DATE_CONVERSION = 2302,
+    // (undocumented)
     LCP_IMG_MISSING_PRIORITY = 2955,
     // (undocumented)
     LCP_IMG_NGSRC_MODIFIED = 2964,
@@ -51,7 +53,13 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     UNEXPECTED_SRC_ATTR = 2950,
     // (undocumented)
-    UNEXPECTED_SRCSET_ATTR = 2951
+    UNEXPECTED_SRCSET_ATTR = 2951,
+    // (undocumented)
+    UNEXPECTED_TRANSLATION_TYPE = 2302,
+    // (undocumented)
+    UNKNOWN_DATE_TYPE_VALUE = 2301,
+    // (undocumented)
+    UNKNOWN_ZONE_WIDTH = 2302
 }
 
 // (No @packageDocumentation comment for this package)

goldens/public-api/common/http/errors.api.md

@@ -15,6 +15,12 @@ export const enum RuntimeErrorCode {
     // (undocumented)
     HTTP_ORIGIN_MAP_USED_IN_CLIENT = 2803,
     // (undocumented)
+    JSONP_HEADERS_NOT_SUPPORTED = 2812,
+    // (undocumented)
+    JSONP_WRONG_METHOD = 2810,
+    // (undocumented)
+    JSONP_WRONG_RESPONSE_TYPE = 2811,
+    // (undocumented)
     MISSING_JSONP_MODULE = -2800,
     // (undocumented)
     NOT_USING_FETCH_BACKEND_IN_SSR = 2801,

packages/common/http/src/errors.ts

@@ -21,4 +21,7 @@ export const enum RuntimeErrorCode {
   RESPONSE_IS_NOT_A_BLOB = 2807,
   RESPONSE_IS_NOT_A_STRING = 2808,
   UNHANDLED_OBSERVE_TYPE = 2809,
+  JSONP_WRONG_METHOD = 2810,
+  JSONP_WRONG_RESPONSE_TYPE = 2811,
+  JSONP_HEADERS_NOT_SUPPORTED = 2812,
 }

packages/common/http/src/jsonp.ts

@@ -13,6 +13,7 @@ import {
   inject,
   Injectable,
   runInInjectionContext,
+  ɵRuntimeError as RuntimeError,
 } from '@angular/core';
 import {Observable, Observer} from 'rxjs';
 
@@ -26,6 +27,7 @@ import {
   HttpEventType,
   HttpResponse,
 } from './response';
+import {RuntimeErrorCode} from './errors';
 
 // Every request made through JSONP needs a callback name that's unique across the
 // whole page. Each request is assigned an id and the callback name is constructed
@@ -115,15 +117,24 @@ export class JsonpClientBackend implements HttpBackend {
     // Firstly, check both the method and response type. If either doesn't match
     // then the request was improperly routed here and cannot be handled.
     if (req.method !== 'JSONP') {
-      throw new Error(JSONP_ERR_WRONG_METHOD);
+      throw new RuntimeError(
+        RuntimeErrorCode.JSONP_WRONG_METHOD,
+        ngDevMode && JSONP_ERR_WRONG_METHOD,
+      );
     } else if (req.responseType !== 'json') {
-      throw new Error(JSONP_ERR_WRONG_RESPONSE_TYPE);
+      throw new RuntimeError(
+        RuntimeErrorCode.JSONP_WRONG_RESPONSE_TYPE,
+        ngDevMode && JSONP_ERR_WRONG_RESPONSE_TYPE,
+      );
     }
 
     // Check the request headers. JSONP doesn't support headers and
     // cannot set any that were supplied.
     if (req.headers.keys().length > 0) {
-      throw new Error(JSONP_ERR_HEADERS_NOT_SUPPORTED);
+      throw new RuntimeError(
+        RuntimeErrorCode.JSONP_HEADERS_NOT_SUPPORTED,
+        ngDevMode && JSONP_ERR_HEADERS_NOT_SUPPORTED,
+      );
     }
 
     // Everything else happens inside the Observable boundary.
@@ -178,7 +189,7 @@ export class JsonpClientBackend implements HttpBackend {
       // if the JSONP script loads successfully. The event itself is unimportant.
       // If something went wrong, onLoad() may run without the response callback
       // having been invoked.
-      const onLoad = (event: Event) => {
+      const onLoad = () => {
         // We wrap it in an extra Promise, to ensure the microtask
         // is scheduled after the loaded endpoint has executed any potential microtask itself,
         // which is not guaranteed in Internet Explorer and EdgeHTML. See issue #39496
@@ -220,7 +231,7 @@ export class JsonpClientBackend implements HttpBackend {
       // onError() is the error callback, which runs if the script returned generates
       // a Javascript error. It emits the error via the Observable error channel as
       // a HttpErrorResponse.
-      const onError: any = (error: Error) => {
+      const onError = (error: Error) => {
         cleanup();
 
         // Wrap the error in a HttpErrorResponse.

packages/common/http/test/jsonp_spec.ts

@@ -90,7 +90,7 @@ describe('JsonpClientBackend', () => {
   describe('throws an error', () => {
     it('when request method is not JSONP', () =>
       expect(() => backend.handle(SAMPLE_REQ.clone<never>({method: 'GET'}))).toThrowError(
-        JSONP_ERR_WRONG_METHOD,
+        `NG02810: ${JSONP_ERR_WRONG_METHOD}`,
       ));
     it('when response type is not json', () =>
       expect(() =>
@@ -99,15 +99,15 @@ describe('JsonpClientBackend', () => {
             responseType: 'text',
           }),
         ),
-      ).toThrowError(JSONP_ERR_WRONG_RESPONSE_TYPE));
+      ).toThrowError(`NG02811: ${JSONP_ERR_WRONG_RESPONSE_TYPE}`));
     it('when headers are set in request', () =>
       expect(() =>
         backend.handle(
           SAMPLE_REQ.clone<never>({
             headers: new HttpHeaders({'Content-Type': 'application/json'}),
           }),
         ),
-      ).toThrowError(JSONP_ERR_HEADERS_NOT_SUPPORTED));
+      ).toThrowError(`NG02812: ${JSONP_ERR_HEADERS_NOT_SUPPORTED}`));
     it('when callback is never called', (done) => {
       backend.handle(SAMPLE_REQ).subscribe(undefined, (err: HttpErrorResponse) => {
         expect(err.status).toBe(0);

packages/common/src/errors.ts

@@ -26,6 +26,10 @@ export const enum RuntimeErrorCode {
 
   // I18n errors
   SUSPICIOUS_DATE_FORMAT = 2300,
+  UNKNOWN_DATE_TYPE_VALUE = 2301,
+  UNEXPECTED_TRANSLATION_TYPE = 2302,
+  UNKNOWN_ZONE_WIDTH = 2302,
+  INVALID_TO_DATE_CONVERSION = 2302,
 
   // Keep 2800 - 2900 for Http Errors.
 

packages/common/src/i18n/format_date.ts

@@ -26,7 +26,6 @@ import {
   getLocaleNumberSymbol,
   getLocaleTimeFormat,
   NumberSymbol,
-  Time,
   TranslationWidth,
 } from './locale_data_api';
 import {RuntimeErrorCode} from '../errors';
@@ -349,7 +348,10 @@ function getDatePart(part: DateType, date: Date): number {
     case DateType.Day:
       return date.getDay();
     default:
-      throw new Error(`Unknown DateType value "${part}".`);
+      throw new RuntimeError(
+        RuntimeErrorCode.UNKNOWN_DATE_TYPE_VALUE,
+        ngDevMode && `Unknown DateType value "${part}".`,
+      );
   }
 }
 
@@ -435,7 +437,10 @@ function getDateTranslation(
       // The `throw new Error` below works around the problem, and the unexpected: never variable
       // makes sure tsc still checks this code is unreachable.
       const unexpected: never = name;
-      throw new Error(`unexpected translation type ${unexpected}`);
+      throw new RuntimeError(
+        RuntimeErrorCode.UNEXPECTED_TRANSLATION_TYPE,
+        ngDevMode && `unexpected translation type ${unexpected}`,
+      );
   }
 }
 
@@ -478,7 +483,10 @@ function timeZoneGetter(width: ZoneWidth): DateFormatter {
           );
         }
       default:
-        throw new Error(`Unknown zone width "${width}"`);
+        throw new RuntimeError(
+          RuntimeErrorCode.UNKNOWN_ZONE_WIDTH,
+          ngDevMode && `Unknown zone width "${width}"`,
+        );
     }
   };
 }
@@ -938,7 +946,10 @@ export function toDate(value: string | number | Date): Date {
 
   const date = new Date(value as any);
   if (!isDate(date)) {
-    throw new Error(`Unable to convert "${value}" into a date`);
+    throw new RuntimeError(
+      RuntimeErrorCode.INVALID_TO_DATE_CONVERSION,
+      ngDevMode && `Unable to convert "${value}" into a date`,
+    );
   }
   return date;
 }