Skip to content

Commit 5cbe02a

Browse files
arturovtdevversion
authored andcommitted
refactor(docs-infra): cleanup AfterRenderSequence for reference list (angular#58030)
In this commit, we're replacing the provided injector in `afterNextRender` with a node injector because it was previously mistakenly passing an `EnvironmentInjector`. The `EnvironmentInjector` resolves `DestroyRef` to itself, meaning that `AfterRenderSequence` is essentially never destroyed (since the environment injector is not destroyed either). PR Close angular#58030
1 parent 9e32cc4 commit 5cbe02a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

adev/src/app/features/references/api-reference-list/api-reference-list.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
ChangeDetectionStrategy,
1111
Component,
1212
ElementRef,
13-
EnvironmentInjector,
13+
Injector,
1414
afterNextRender,
1515
computed,
1616
effect,
@@ -43,7 +43,7 @@ export default class ApiReferenceList {
4343
private readonly apiReferenceManager = inject(ApiReferenceManager);
4444
private readonly router = inject(Router);
4545
filterInput = viewChild.required(TextField, {read: ElementRef});
46-
private readonly injector = inject(EnvironmentInjector);
46+
private readonly injector = inject(Injector);
4747

4848
private readonly allGroups = this.apiReferenceManager.apiGroups;
4949

0 commit comments

Comments
 (0)