Skip to content

Commit 6844103

Browse files
vladboisadevversion
authored andcommitted
fix(docs-infra): max-height IDE error panel visibility (angular#54128)
Remove max-height: 200px in ul child inline-errors-box, add the overflow & max-height in percentages to the parent for correct visualization Fixes angular#52760 refactor(docs-infra): correct typo Correct typo in comment feat(docs-infra): modify the height of the editor If error box are displayed, modify the height of the editor PR Close angular#54128
1 parent 1d18b07 commit 6844103

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

adev/src/app/editor/code-editor/code-editor.component.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,8 @@
137137
background-color: color-mix(in srgb, var(--bright-blue), var(--page-background) 90%);
138138
border: 1px solid color-mix(in srgb, var(--bright-blue), var(--page-background) 70%);
139139
border-radius: 0.25rem;
140+
overflow: auto;
141+
max-height: 25%;
140142

141143
button {
142144
position: absolute;
@@ -162,7 +164,6 @@
162164
margin: 0;
163165
margin-inline: 1.25rem;
164166
color: var(--tertiary-contrast);
165-
max-height: 200px;
166167
overflow: auto;
167168
}
168169
}

adev/src/app/editor/embedded-editor.component.scss

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ $width-breakpoint: 950px;
3232
}
3333
}
3434

35-
// If files are displayed, shpare the space
35+
// If error box are displayed, modify the height of the editor
36+
&:has(.adev-inline-errors-box) {
37+
.adev-code-editor-wrapper {
38+
height: calc(50% - 33px) ;
39+
}
40+
}
41+
// If files are displayed, share the space
3642
&:has(.docs-editor-tabs) {
3743
.adev-tutorial-code-editor {
3844
display: block;

0 commit comments

Comments
 (0)