Skip to content

Commit 8358c19

Browse files
alan-agius4mmalerba
authored andcommitted
test: address flakiness in e2e tests (angular#64219)
It was noted that there are some flakes in CI. Using seed '29976' it was narrowed down to the e2e tests for the vscode extension. PR Close angular#64219
1 parent 5739890 commit 8358c19

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

vscode-ng-language-service/integration/e2e/BUILD.bazel

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,13 @@ js_test(
2727
":e2e",
2828
"//vscode-ng-language-service:node_modules/jasmine",
2929
"//vscode-ng-language-service:node_modules/jasmine-reporters",
30-
"//vscode-ng-language-service:node_modules/typescript",
3130
"//vscode-ng-language-service:node_modules/xvfb",
3231
"//vscode-ng-language-service:npm",
3332
"//vscode-ng-language-service/integration/project",
3433
"//vscode-ng-language-service/integration/project:node_modules/@angular/common",
3534
"//vscode-ng-language-service/integration/project:node_modules/@angular/core",
35+
"//vscode-ng-language-service/server:node_modules/@angular/language-service",
36+
"//vscode-ng-language-service/server:node_modules/typescript",
3637
],
3738
entry_point = ":index.js",
3839
env = {

vscode-ng-language-service/integration/e2e/helper.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ export const FOO_TEMPLATE_URI = vscode.Uri.file(FOO_TEMPLATE);
1111

1212
export async function activate(uri: vscode.Uri): Promise<void> {
1313
await vscode.window.showTextDocument(uri);
14+
15+
// This is needed for stabilization and to reduce flakes.
16+
// The timeout gives the language server time to warm up.
17+
await setTimeout(3_000);
18+
1419
await waitForDefinitionsToBeAvailable(20);
1520
}
1621

vscode-ng-language-service/server/src/BUILD.bazel

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ ts_project(
55
srcs = glob(["*.ts"]),
66
declaration = True,
77
source_map = True,
8-
tags = [
9-
# Because the testing intentionally reaches into the output directories and crosses the sandbox
10-
# boundaries, we need to explicitly make sure that this target is built locally so the testing
11-
# can find expected files.
12-
"no-remote-exec",
13-
],
148
tsconfig = "//vscode-ng-language-service/server:tsconfig",
159
visibility = [
1610
"//vscode-ng-language-service/server:__subpackages__",

0 commit comments

Comments
 (0)