Skip to content

Commit 91c4f99

Browse files
MeAkibmmalerba
authored andcommitted
refactor(docs-infra): improve CustomErrorHandler for clarity and best practices (angular#64237)
Use `implements ErrorHandler` instead of extending the base class to follow Angular conventions. Marked injected dependencies as `readonly`, made `openErrorSnackBar` private, and improved overall code consistency. PR Close angular#64237
1 parent 62bbce6 commit 91c4f99

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

adev/src/app/core/services/errors-handling/error-handler.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ import {AnalyticsService} from '../analytics/analytics.service';
1313
import {ErrorSnackBar, ErrorSnackBarData} from './error-snack-bar';
1414

1515
export class CustomErrorHandler implements ErrorHandler {
16-
snackBar = inject(MatSnackBar);
17-
document = inject(DOCUMENT);
18-
isServer = isPlatformServer(inject(PLATFORM_ID));
19-
analyticsService = inject(AnalyticsService);
16+
private readonly snackBar = inject(MatSnackBar);
17+
private readonly document = inject(DOCUMENT);
18+
private readonly isServer = isPlatformServer(inject(PLATFORM_ID));
19+
private readonly analyticsService = inject(AnalyticsService);
2020

2121
get isOnline(): boolean {
2222
if (this.isServer) return false;
@@ -42,7 +42,7 @@ export class CustomErrorHandler implements ErrorHandler {
4242
console.error(error);
4343
}
4444

45-
openErrorSnackBar(): void {
45+
private openErrorSnackBar(): void {
4646
this.snackBar
4747
.openFromComponent(ErrorSnackBar, {
4848
panelClass: 'docs-invert-mode',

0 commit comments

Comments
 (0)