docs(docs-infra): makes signal readonly (angular#63449)

PR Close angular#63449

Author: MeAkib

adev/shared-docs/services/navigation-state.service.ts

@@ -119,7 +119,7 @@ export class NavigationState {
   /**
    * return the actual navigation items, that is to say the one that match the current level
    */
-  private actualExpandedItems() {
+  private actualExpandedItems(): NavigationItem[] {
     return this.expandedItems().slice(0, this.level());
   }
 

adev/shared-docs/services/search-history.service.ts

@@ -29,22 +29,22 @@ export class SearchHistory {
   private readonly localStorage = inject(LOCAL_STORAGE);
   private readonly history = signal<Map<string, HistoryItem>>(new Map());
 
-  private allItems = computed(() =>
+  private readonly allItems = computed(() =>
     Array.from(this.history().values()).sort((a, b) => b.createdAt - a.createdAt),
   );
 
-  items = computed<{recent: HistoryItem[]; favorite: HistoryItem[]}>(() => ({
+  readonly items = computed<{recent: HistoryItem[]; favorite: HistoryItem[]}>(() => ({
     recent: this.allItems().filter((v) => !v.isFavorite),
     favorite: this.allItems().filter((v) => v.isFavorite),
   }));
 
-  hasItems = computed(() => this.allItems().length > 0);
+  readonly hasItems = computed(() => this.allItems().length > 0);
 
   constructor() {
     this.loadHistory();
   }
 
-  addItem(item: SearchResultItem | HistoryItem) {
+  addItem(item: SearchResultItem | HistoryItem): void {
     this.updateHistory((map) => {
       const labelHtml = (item.labelHtml || '').replace(/<\/?mark>/g, '');
 
@@ -64,13 +64,13 @@ export class SearchHistory {
     });
   }
 
-  removeItem(item: SearchResultItem | HistoryItem) {
+  removeItem(item: SearchResultItem | HistoryItem): void {
     this.updateHistory((map) => {
       map.delete(item.id);
     });
   }
 
-  makeFavorite(item: SearchResultItem | HistoryItem) {
+  makeFavorite(item: SearchResultItem | HistoryItem): void {
     this.updateHistory((map) => {
       const updated = map.get(item.id);
       if (updated) {
@@ -83,7 +83,7 @@ export class SearchHistory {
     });
   }
 
-  private loadHistory() {
+  private loadHistory(): void {
     let parsedData: HistoryItem[];
 
     try {
@@ -100,7 +100,7 @@ export class SearchHistory {
     this.history.set(history);
   }
 
-  private updateHistory(updateFn: (map: Map<string, HistoryItem>) => void) {
+  private updateHistory(updateFn: (map: Map<string, HistoryItem>) => void): void {
     const history = new Map(this.history());
     updateFn(history);
     this.history.set(history);

adev/shared-docs/services/search.service.ts

@@ -48,7 +48,7 @@ export class Search {
   private readonly config = inject(ENVIRONMENT);
   private readonly client = inject(ALGOLIA_CLIENT);
 
-  resultsResource = resource({
+  readonly resultsResource = resource({
     params: () => this.searchQuery() || undefined, // coerces empty string to undefined
     loader: async ({params: query, abortSignal}) => {
       // Until we have a better alternative we debounce by awaiting for a short delay.
@@ -97,7 +97,7 @@ export class Search {
     },
   });
 
-  searchResults = linkedSignal<SearchResultItem[] | undefined, SearchResultItem[]>({
+  readonly searchResults = linkedSignal<SearchResultItem[] | undefined, SearchResultItem[]>({
     source: this.resultsResource.value,
     computation: (next, prev) => (!next && this.searchQuery() ? prev?.value : next) ?? [],
   });
@@ -219,7 +219,7 @@ function matched(snippet: SnippetResult | undefined): boolean {
 /**
  * Temporary helper to implement the debounce functionality on the search resource
  */
-function wait(ms: number, signal: AbortSignal) {
+function wait(ms: number, signal: AbortSignal): Promise<void> {
   return new Promise<void>((resolve, reject) => {
     const timeout = setTimeout(() => resolve(), ms);