build: use @angular/language-service from source (angular#64306)

This commit updates the VSCode Angular Language Service extension to use the `@angular/language-service` package built from source within the workspace, rather than a version downloaded from npm.

This change simplifies development and testing by ensuring the extension always uses the latest code from the local repository. The Bazel build configuration, VSCode launch settings, and e2e tests have been updated to reflect this change.

PR Close angular#64306

Author: alan-agius4

.vscode/launch.json

@@ -20,7 +20,7 @@
       "runtimeExecutable": "${execPath}",
       "args": [
         "--disable-extensions",
-        "--extensionDevelopmentPath=${workspaceFolder}/dist/bin/vscode-ng-language-service/npm/vscode-ng-language-service/vsix_sandbox"
+        "--extensionDevelopmentPath=${workspaceFolder}/dist/bin/vscode-ng-language-service/development_package"
       ],
       "preLaunchTask": "VSCE: package"
     },

pnpm-lock.yaml

@@ -23,9 +23,10 @@ expand_template_rule(
     name = "package_json_expanded",
     out = "package_expanded.json",
     stamp_substitutions = {
-        "0.0.0-PLACEHOLDER": "{{BUILD_SCM_VERSION}}",
+        "workspace:*": "{{STABLE_PROJECT_VERSION}}",
     },
     substitutions = {
+        "workspace:*": "0.0.0",
         "../dist/bin/vscode-ng-language-service/client/src/extension.js": "./index",
     },
     template = "package.json",
@@ -34,12 +35,12 @@ expand_template_rule(
 npm_package(
     name = "vsix_sandbox",
     srcs = [
-        "package_expanded.json",
-        "angular.png",
         "CHANGELOG.md",
         "README.md",
+        "angular.png",
+        "package_expanded.json",
         "//vscode-ng-language-service/client:index.js",
-        "//vscode-ng-language-service/server:npm_files",
+        "//vscode-ng-language-service/server:npm_package",
         "//vscode-ng-language-service/syntaxes:npm_files",
         # Transitive closure of npm deps that are marked as "external" in esbuild needed for vsce;
         # this set was determined manually by running `bazel build //:vsix` and burning down missing packages.
@@ -56,7 +57,7 @@ npm_package(
     ],
     replace_prefixes = {
         "package_expanded.json": "package.json",
-        "server/package_expanded.json": "server/package.json",
+        "server/npm_package/": "server/",
         "client/": "",
         "syntaxes/src/": "syntaxes/",
     },
@@ -82,16 +83,14 @@ vsce_bin.vsce(
 )
 
 npm_package(
-    name = "npm",
+    name = "development_package",
     srcs = [
         ":vsix",
         ":vsix_sandbox",
     ],
-    data = [
-        "//vscode-ng-language-service:node_modules/@angular/language-service",
-    ],
     root_paths = [
-        "vsix_sandbox",
+        "vscode-ng-language-service/vsix_sandbox",
+        "vscode-ng-language-service",
     ],
-    visibility = ["//vscode-ng-language-service/integration:__subpackages__"],
+    visibility = ["//vscode-ng-language-service/integration/e2e:__subpackages__"],
 )

vscode-ng-language-service/BUILD.bazel

@@ -70,7 +70,8 @@ export class Version {
   }
 
   isVersionZero() {
-    return this.versionStr === '0.0.0';
+    // Handle both `0.0.0`, `0.0.0-PLACEHOLDER` and similar
+    return this.major === 0 && this.minor === 0 && this.patch === 0;
   }
 
   toString(): string {

vscode-ng-language-service/common/resolver.ts

@@ -30,7 +30,7 @@ js_test(
     name = "test",
     data = [
         ":e2e",
-        "//vscode-ng-language-service:npm",
+        "//vscode-ng-language-service:development_package",
     ],
     entry_point = ":index.js",
     env = {

vscode-ng-language-service/integration/e2e/BUILD.bazel

@@ -9,7 +9,7 @@ import {mkdtemp} from 'node:fs/promises';
 import Xvfb from 'xvfb';
 
 async function main() {
-  const EXT_DEVELOPMENT_PATH = join(PACKAGE_ROOT, 'npm/vscode-ng-language-service/vsix_sandbox');
+  const EXT_DEVELOPMENT_PATH = join(PACKAGE_ROOT, 'development_package');
   const EXT_TESTS_PATH = join(PACKAGE_ROOT, 'integration', 'e2e', 'jasmine');
   const xvfb = new Xvfb();
 

vscode-ng-language-service/integration/e2e/index.ts

@@ -2,7 +2,8 @@
   "name": "ng-template",
   "displayName": "Angular Language Service",
   "description": "Editor services for Angular templates",
-  "version": "20.2.2",
+  "version": "0.0.0",
+  "private": true,
   "publisher": "Angular",
   "icon": "angular.png",
   "license": "MIT",
@@ -246,7 +247,7 @@
   "scripts": {
     "build:syntaxes": "bazel run //vscode-ng-language-service/syntaxes:syntaxes",
     "watch": "ibazel build //vscode-ng-language-service/client/src //vscode-ng-language-service/server/src",
-    "package": "bazel build //vscode-ng-language-service:npm --config=release",
+    "package": "bazel build //vscode-ng-language-service:development_package --config=release",
     "test": "bazel test --test_tag_filters=unit_test //vscode-ng-language-service/...",
     "test:watch": "ibazel test --test_tag_filters=unit_test //vscode-ng-language-service/...",
     "test:lsp": "bazel test --test_output=streamed //vscode-ng-language-service/integration/lsp:test",
@@ -257,10 +258,9 @@
     "test:inspect-syntaxes": "bazel run --config=debug //vscode-ng-language-service/syntaxes/test:test"
   },
   "dependencies": {
-    "@angular/language-service": "21.0.0-next.7"
+    "@angular/language-service": "workspace:*"
   },
   "devDependencies": {
-    "@angular/core": "21.0.0-next.7",
     "@types/jasmine": "~5.1.9",
     "@types/jasmine-reporters": "~2.5.3",
     "@types/node": "^24.5.2",

vscode-ng-language-service/package.json

@@ -1,5 +1,6 @@
 load("@aspect_bazel_lib//lib:expand_template.bzl", "expand_template_rule")
 load("@aspect_rules_esbuild//esbuild:defs.bzl", "esbuild")
+load("@aspect_rules_js//npm:defs.bzl", "npm_package")
 load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 
@@ -73,21 +74,27 @@ expand_template_rule(
     name = "package_json_expanded",
     out = "package_expanded.json",
     stamp_substitutions = {
-        "0.0.0-PLACEHOLDER": "{{BUILD_SCM_VERSION}}",
+        "0.0.0-PLACEHOLDER": "{{STABLE_PROJECT_VERSION}}",
+        "workspace:*": "{{STABLE_PROJECT_VERSION}}",
     },
     substitutions = {
+        "0.0.0-PLACEHOLDER": "0.0.0",
+        "workspace:*": "0.0.0",
         "../../dist/bin/vscode-ng-language-service/server/src/server.js": "./index.js",
     },
     template = "package.json",
 )
 
-filegroup(
-    name = "npm_files",
+npm_package(
+    name = "npm_package",
     srcs = [
         "README.md",
         "bin/ngserver",
         "index.js",
         "package_expanded.json",
     ],
+    replace_prefixes = {
+        "package_expanded.json": "package.json",
+    },
     visibility = ["//vscode-ng-language-service:__pkg__"],
 )

vscode-ng-language-service/server/BUILD.bazel

@@ -17,7 +17,7 @@
     "ngserver": "./bin/ngserver"
   },
   "dependencies": {
-    "@angular/language-service": "21.0.0-next.7",
+    "@angular/language-service": "workspace:*",
     "typescript": "5.9.3"
   },
   "devDependencies": {