Skip to content

Commit c0f41bc

Browse files
crisbetoatscott
authored andcommitted
refactor(platform-browser): remove GenericBrowserDomAdapter (angular#60760)
The `GenericBrowserDomAdapter` wasn't don't anything so we can drop it and have the `BrowserDomAdapter` extend `DomAdapter` directly. PR Close angular#60760
1 parent 155e661 commit c0f41bc

File tree

10 files changed

+4
-30
lines changed

10 files changed

+4
-30
lines changed

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@
8080
"EventManager",
8181
"EventManagerPlugin",
8282
"FALSE_BOOLEAN_VALUES",
83-
"GenericBrowserDomAdapter",
8483
"INJECTOR",
8584
"INJECTOR_DEF_TYPES",
8685
"INJECTOR_SCOPE",

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656
"EventEmitter",
5757
"EventManager",
5858
"EventManagerPlugin",
59-
"GenericBrowserDomAdapter",
6059
"INJECTOR",
6160
"INJECTOR_DEF_TYPES",
6261
"INJECTOR_SCOPE",

packages/core/test/bundling/defer/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"EventEmitter",
7474
"EventManager",
7575
"EventManagerPlugin",
76-
"GenericBrowserDomAdapter",
7776
"HYDRATE_TRIGGER_CLEANUP_FNS",
7877
"INJECTOR",
7978
"INJECTOR_DEF_TYPES",

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
"FormResetEvent",
8888
"FormSubmittedEvent",
8989
"FormsExampleModule",
90-
"GenericBrowserDomAdapter",
9190
"INJECTOR",
9291
"INJECTOR_DEF_TYPES",
9392
"INJECTOR_SCOPE",

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@
8080
"FormGroup",
8181
"FormsExampleModule",
8282
"FormsModule",
83-
"GenericBrowserDomAdapter",
8483
"INJECTOR",
8584
"INJECTOR_DEF_TYPES",
8685
"INJECTOR_SCOPE",

packages/core/test/bundling/hydration/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
"EventEmitter",
5555
"EventManager",
5656
"EventManagerPlugin",
57-
"GenericBrowserDomAdapter",
5857
"HEADERS",
5958
"HTTP_ROOT_INTERCEPTOR_FNS",
6059
"HTTP_TRANSFER_CACHE_ORIGIN_MAP",

packages/core/test/bundling/router/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@
8181
"EventManager",
8282
"EventManagerPlugin",
8383
"EventType2",
84-
"GenericBrowserDomAdapter",
8584
"GuardsCheckEnd",
8685
"GuardsCheckStart",
8786
"HistoryStateManager",

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
"EventEmitter",
5252
"EventManager",
5353
"EventManagerPlugin",
54-
"GenericBrowserDomAdapter",
5554
"INJECTOR",
5655
"INJECTOR_DEF_TYPES",
5756
"INJECTOR_SCOPE",

packages/platform-browser/src/browser/browser_adapter.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,18 @@
99
import {
1010
ɵparseCookieValue as parseCookieValue,
1111
ɵsetRootDomAdapter as setRootDomAdapter,
12+
ɵDomAdapter as DomAdapter,
1213
} from '@angular/common';
1314

14-
import {GenericBrowserDomAdapter} from './generic_browser_adapter';
15-
1615
/**
1716
* A `DomAdapter` powered by full browser DOM APIs.
1817
*
1918
* @security Tread carefully! Interacting with the DOM directly is dangerous and
2019
* can introduce XSS risks.
2120
*/
22-
export class BrowserDomAdapter extends GenericBrowserDomAdapter {
21+
export class BrowserDomAdapter extends DomAdapter {
22+
override readonly supportsDOMEvents: boolean = true;
23+
2324
static makeCurrent() {
2425
setRootDomAdapter(new BrowserDomAdapter());
2526
}

packages/platform-browser/src/browser/generic_browser_adapter.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

0 commit comments

Comments
 (0)