docs(docs-infra): remove costly localeCompare (angular#59106)

This function wasn't necessary, the items where already sorted.

fixes #59069d

PR Close angular#59106

Author: JeanMeche

adev/shared-docs/pipeline/api-gen/manifest/generate_manifest.ts

@@ -86,6 +86,11 @@ export function generateManifest(apiCollections: EntryCollection[]): Manifest {
     }
   }
 
+  // We sort the API entries alphabetically by name to ensure a stable order in the manifest.
+  manifest.forEach((entry) => {
+    entry.entries.sort((entry1, entry2) => entry1.name.localeCompare(entry2.name));
+  });
+
   manifest.sort((entry1, entry2) => {
     // Ensure that labels that start with a `code` tag like `window.ng` are last
     if (entry1.moduleLabel.startsWith('<')) {

adev/shared-docs/pipeline/api-gen/manifest/test/manifest.spec.ts

@@ -13,26 +13,40 @@ import {generateManifest, Manifest} from '../generate_manifest';
 describe('api manifest generation', () => {
   it('should generate a manifest from multiple collections', () => {
     const manifest: Manifest = generateManifest([
+      {
+        moduleName: '@angular/router',
+        entries: [entry({name: 'Router', entryType: EntryType.UndecoratedClass})],
+        normalizedModuleName: 'angular_router',
+        moduleLabel: 'router',
+      },
       {
         moduleName: '@angular/core',
         entries: [entry({name: 'PI', entryType: EntryType.Constant})],
         normalizedModuleName: 'angular_core',
         moduleLabel: 'core',
       },
       {
-        moduleName: '@angular/router',
-        entries: [entry({name: 'Router', entryType: EntryType.UndecoratedClass})],
-        normalizedModuleName: 'angular_router',
-        moduleLabel: 'router',
+        moduleName: '@angular/core',
+        entries: [entry({name: 'foo', entryType: EntryType.Constant})],
+        normalizedModuleName: 'angular_core',
+        moduleLabel: 'core',
       },
     ]);
 
+    // The test also makes sure that we sort modules & entries by name.
     expect(manifest).toEqual([
       {
         moduleName: '@angular/core',
         moduleLabel: 'core',
         normalizedModuleName: 'angular_core',
         entries: [
+          {
+            name: 'foo',
+            type: EntryType.Constant,
+            isDeprecated: false,
+            isDeveloperPreview: false,
+            isExperimental: false,
+          },
           {
             name: 'PI',
             type: EntryType.Constant,

adev/src/app/features/references/helpers/manifest.helper.ts

@@ -43,12 +43,10 @@ export function getApiNavigationItems(): NavigationItem[] {
   for (const packageEntry of manifest) {
     const packageNavigationItem: NavigationItem = {
       label: packageEntry.moduleLabel,
-      children: packageEntry.entries
-        .map((api) => ({
-          path: getApiUrl(packageEntry, api.name),
-          label: api.name,
-        }))
-        .sort((a, b) => a.label.localeCompare(b.label)),
+      children: packageEntry.entries.map((api) => ({
+        path: getApiUrl(packageEntry, api.name),
+        label: api.name,
+      })),
     };
 
     apiNavigationItems.push(packageNavigationItem);