docs(docs-infra): properties should be readonly (angular#63492)

PR Close angular#63492

Author: MeAkib

adev/shared-docs/components/breadcrumb/breadcrumb.component.ts

@@ -21,7 +21,7 @@ import {RouterLink} from '@angular/router';
 export class Breadcrumb {
   private readonly navigationState = inject(NavigationState);
 
-  breadcrumbItems = computed(() => {
+  readonly breadcrumbItems = computed(() => {
     const breadcrumbs: NavigationItem[] = [];
     let activeItem = this.navigationState.activeNavigationItem()?.parent;
 

adev/shared-docs/components/cookie-popup/cookie-popup.component.ts

@@ -27,7 +27,7 @@ export class CookiePopup {
   private readonly localStorage = inject(LOCAL_STORAGE);
 
   /** Whether the user has accepted the cookie disclaimer. */
-  hasAccepted = signal<boolean>(false);
+  readonly hasAccepted = signal<boolean>(false);
 
   constructor() {
     // Needs to be in a try/catch, because some browsers will

adev/shared-docs/components/table-of-contents/table-of-contents.component.ts

@@ -38,7 +38,7 @@ export class TableOfContents {
 
   tableOfContentItems = this.tableOfContentsLoader.tableOfContentItems;
 
-  activeItemId = signal<string | null>(null);
+  readonly activeItemId = signal<string | null>(null);
   TableOfContentsLevel = TableOfContentsLevel;
 
   constructor() {

adev/shared-docs/components/viewers/example-viewer/example-viewer.component.ts

@@ -72,17 +72,17 @@ export class ExampleViewer {
   CodeExampleViewMode = CodeExampleViewMode;
   exampleComponent?: Type<unknown>;
 
-  expandable = signal<boolean>(false);
-  expanded = signal<boolean>(false);
-  snippetCode = signal<Snippet | undefined>(undefined);
-  tabs = computed(() =>
+  readonly expandable = signal<boolean>(false);
+  readonly expanded = signal<boolean>(false);
+  readonly snippetCode = signal<Snippet | undefined>(undefined);
+  readonly tabs = computed(() =>
     this.exampleMetadata()?.files.map((file) => ({
       name:
         file.title ?? (this.shouldDisplayFullName() ? file.name : this.getFileExtension(file.name)),
       code: file.sanitizedContent,
     })),
   );
-  view = computed(() =>
+  readonly view = computed(() =>
     this.exampleMetadata()?.files.length === 1
       ? CodeExampleViewMode.SNIPPET
       : CodeExampleViewMode.MULTI_FILE,

adev/shared-docs/directives/search-item/search-item.directive.ts

@@ -21,7 +21,7 @@ export class SearchItem implements Highlightable {
   // We can't migrate them to signals yet
   @Input() disabled = false;
 
-  item = input<SearchResultItem | undefined>();
+  readonly item = input<SearchResultItem | undefined>();
 
   private readonly elementRef = inject(ElementRef<HTMLLIElement>);
 

adev/shared-docs/services/navigation-state.service.ts

@@ -21,7 +21,7 @@ export class NavigationState {
   private readonly _isMobileNavVisible = signal<boolean>(false);
   private readonly _level = linkedSignal(() => this._expandedItems().length);
 
-  primaryActiveRouteItem = signal<string | null>(null);
+  readonly primaryActiveRouteItem = signal<string | null>(null);
   activeNavigationItem = this._activeNavigationItem.asReadonly();
   expandedItems = this._expandedItems.asReadonly();
   isMobileNavVisible = this._isMobileNavVisible.asReadonly();

adev/src/app/core/layout/secondary-navigation/secondary-navigation.component.ts

@@ -58,7 +58,7 @@ export class SecondaryNavigation {
 
   navigationItems: NavigationItem[] | undefined;
 
-  translateX = computed(() => {
+  readonly translateX = computed(() => {
     const level = this.navigationState.level();
     return `translateX(${-level * 100}%)`;
   });

adev/src/app/core/services/version-manager.service.ts

@@ -53,7 +53,7 @@ export class VersionManager {
   });
 
   // This handle the fallback if the resource fails.
-  versions = computed(() => {
+  readonly versions = computed(() => {
     return this.remoteVersions.hasValue() ? this.remoteVersions.value() : this.localVersions;
   });
 
@@ -93,7 +93,7 @@ export class VersionManager {
     },
   );
 
-  currentDocsVersion = computed(() => {
+  readonly currentDocsVersion = computed(() => {
     // In devmode the version is 0, so we'll target next (which is first on the list)
     if (VERSION.major === '0') {
       return this.versions()[0];

adev/src/app/editor/code-editor/code-mirror-editor.service.ts

@@ -65,9 +65,9 @@ const INITIAL_STATES = {
 @Injectable({providedIn: 'root'})
 export class CodeMirrorEditor {
   // TODO: handle files created by the user, e.g. after running `ng generate component`
-  files = signal<EditorFile[]>(INITIAL_STATES.files);
-  openFiles = signal<EditorFile[]>(INITIAL_STATES.files);
-  currentFile = signal<EditorFile>(INITIAL_STATES.currentFile);
+  readonly files = signal<EditorFile[]>(INITIAL_STATES.files);
+  readonly openFiles = signal<EditorFile[]>(INITIAL_STATES.files);
+  readonly currentFile = signal<EditorFile>(INITIAL_STATES.currentFile);
 
   // An instance of web worker used to run virtual TypeScript environment in the browser.
   // It allows to enrich CodeMirror UX for TypeScript files.

adev/src/app/editor/embedded-editor.component.ts

@@ -53,7 +53,7 @@ export const LARGE_EDITOR_HEIGHT_BREAKPOINT = 550;
 })
 export class EmbeddedEditor {
   // Prevents from adding, removing or renaming files
-  restrictedMode = input<boolean>(false);
+  readonly restrictedMode = input<boolean>(false);
 
   readonly editorContainer = viewChild<ElementRef<HTMLDivElement>>('editorContainer');
   readonly matTabGroup = viewChild(MatTabGroup);
@@ -66,7 +66,7 @@ export class EmbeddedEditor {
   private readonly nodeRuntimeState = inject(NodeRuntimeState);
   private readonly nodeRuntimeSandbox = inject(NodeRuntimeSandbox);
 
-  protected splitDirection = signal<'horizontal' | 'vertical'>('vertical');
+  protected readonly splitDirection = signal<'horizontal' | 'vertical'>('vertical');
 
   readonly MAX_RECOMMENDED_WEBCONTAINERS_INSTANCES = MAX_RECOMMENDED_WEBCONTAINERS_INSTANCES;