build: clean up language service integration tests and Bazel dependencies (angular#64271)

The legacy `workspace` integration test asset folder has been removed as it was unused and no longer representative of modern Angular CLI workspaces.

In line with this cleanup, the Bazel dependency definitions for the integration tests have been reorganized. Runtime data dependencies have been moved from the `js_test` rules to the `data` attribute of their corresponding `ts_project` rules. This is a cleaner and more appropriate approach as it co-locates a test's runtime data dependencies with its source code definition, making the relationship between the code and its required assets more explicit and improving the overall maintainability of the build configuration.

PR Close angular#64271

Author: alan-agius4

.bazelignore

@@ -73,5 +73,4 @@ tools/bazel/rules_angular_store/node_modules
 vscode-ng-language-service/node_modules
 vscode-ng-language-service/server/node_modules
 vscode-ng-language-service/integration/pre_standalone_project/node_modules
-vscode-ng-language-service/integration/workspace/node_modules
 vscode-ng-language-service/integration/project/node_modules

MODULE.bazel

@@ -98,7 +98,6 @@ npm.npm_translate_lock(
         "//tools/bazel/rules_angular_store:package.json",
         "//vscode-ng-language-service/integration/pre_standalone_project:package.json",
         "//vscode-ng-language-service/integration/project:package.json",
-        "//vscode-ng-language-service/integration/workspace:package.json",
     ],
     npmrc = "//:.npmrc",
     pnpm_lock = "//:pnpm-lock.yaml",

pnpm-lock.yaml

@@ -29,7 +29,6 @@ packages:
   - vscode-ng-language-service
   - vscode-ng-language-service/server
   - vscode-ng-language-service/integration/pre_standalone_project
-  - vscode-ng-language-service/integration/workspace
   - vscode-ng-language-service/integration/project
 
 allowedDeprecatedVersions:

pnpm-workspace.yaml

@@ -87,6 +87,9 @@ npm_package(
         ":vsix",
         ":vsix_sandbox",
     ],
+    data = [
+        "//vscode-ng-language-service:node_modules/@angular/language-service",
+    ],
     root_paths = [
         "vsix_sandbox",
     ],

vscode-ng-language-service/BUILD.bazel

@@ -21,6 +21,9 @@ esbuild(
             "main",
         ],
     },
+    data = [
+        "//vscode-ng-language-service:node_modules/@angular/language-service",
+    ],
     entry_point = "//vscode-ng-language-service/client/src:extension.js",
     external = [
         "vscode",

vscode-ng-language-service/client/BUILD.bazel

@@ -14,6 +14,15 @@ ts_project(
     srcs = [
         "test_constants.ts",
     ],
+    data = [
+        "//vscode-ng-language-service/integration/pre_standalone_project",
+        "//vscode-ng-language-service/integration/pre_standalone_project:node_modules/@angular/common",
+        "//vscode-ng-language-service/integration/pre_standalone_project:node_modules/@angular/core",
+        "//vscode-ng-language-service/integration/project",
+        "//vscode-ng-language-service/integration/project:node_modules/@angular/common",
+        "//vscode-ng-language-service/integration/project:node_modules/@angular/core",
+        "//vscode-ng-language-service/server:index",
+    ],
     declaration = True,
     source_map = True,
     tsconfig = "//vscode-ng-language-service:tsconfig",

vscode-ng-language-service/integration/BUILD.bazel

@@ -5,6 +5,11 @@ ts_project(
     name = "e2e",
     testonly = True,
     srcs = glob(["*.ts"]),
+    data = [
+        "//vscode-ng-language-service:node_modules/jasmine",
+        "//vscode-ng-language-service:node_modules/jasmine-reporters",
+        "//vscode-ng-language-service:node_modules/xvfb",
+    ],
     declaration = True,
     source_map = True,
     tsconfig = "//vscode-ng-language-service:tsconfig",
@@ -25,15 +30,7 @@ js_test(
     name = "test",
     data = [
         ":e2e",
-        "//vscode-ng-language-service:node_modules/jasmine",
-        "//vscode-ng-language-service:node_modules/jasmine-reporters",
-        "//vscode-ng-language-service:node_modules/xvfb",
         "//vscode-ng-language-service:npm",
-        "//vscode-ng-language-service/integration/project",
-        "//vscode-ng-language-service/integration/project:node_modules/@angular/common",
-        "//vscode-ng-language-service/integration/project:node_modules/@angular/core",
-        "//vscode-ng-language-service/server:node_modules/@angular/language-service",
-        "//vscode-ng-language-service/server:node_modules/typescript",
     ],
     entry_point = ":index.js",
     env = {

vscode-ng-language-service/integration/e2e/BUILD.bazel

@@ -1,30 +1,15 @@
 load("//tools:defaults.bzl", "jasmine_test", "ts_project")
 
-jasmine_test(
-    name = "test",
-    data = [
-        ":test_lib",
-        "//vscode-ng-language-service/integration",
-        "//vscode-ng-language-service/integration/pre_standalone_project",
-        "//vscode-ng-language-service/integration/pre_standalone_project:node_modules/@angular/common",
-        "//vscode-ng-language-service/integration/pre_standalone_project:node_modules/@angular/core",
-        "//vscode-ng-language-service/integration/project",
-        "//vscode-ng-language-service/integration/project:node_modules/@angular/common",
-        "//vscode-ng-language-service/integration/project:node_modules/@angular/core",
-        "//vscode-ng-language-service/server:index",
-        "//vscode-ng-language-service/server:node_modules/@angular/language-service",
-        "//vscode-ng-language-service/server:node_modules/typescript",
-    ],
-    flaky = True,
-    shard_count = 2,
-)
-
 ts_project(
     name = "test_lib",
     testonly = True,
     srcs = glob([
         "*.ts",
     ]),
+    data = [
+        "//vscode-ng-language-service/integration",
+        "//vscode-ng-language-service/server:index",
+    ],
     tsconfig = "//vscode-ng-language-service/integration:tsconfig-test",
     deps = [
         "//vscode-ng-language-service:node_modules/@types/jasmine",
@@ -36,3 +21,12 @@ ts_project(
         "//vscode-ng-language-service/integration",
     ],
 )
+
+jasmine_test(
+    name = "test",
+    data = [
+        ":test_lib",
+    ],
+    flaky = True,
+    shard_count = 2,
+)

vscode-ng-language-service/integration/lsp/BUILD.bazel

@@ -7,6 +7,6 @@ copy_to_bin(
     name = "pre_standalone_project",
     srcs = glob(["**"]),
     visibility = [
-        "//vscode-ng-language-service/integration/lsp:__pkg__",
+        "//vscode-ng-language-service/integration:__pkg__",
     ],
 )